Skip to content

Conversation

@expenses
Copy link
Contributor

See paritytech/substrate#4612. This merges in #100, but also:

  • Changes rand to be dependent on the test-helpers feature, which means that the crate actually compiles with this feature turned on. This does mean that you have to run cargo test --feature test-helpers to test it though.
  • Adds an Unpin impl for a few types.

@expenses expenses requested a review from rphmeier January 14, 2020 10:16
@parity-cla-bot
Copy link

It looks like @expenses signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@rphmeier
Copy link
Contributor

Changes rand to be dependent on the test-helpers feature, which means that the crate actually compiles with this feature turned on. This does mean that you have to run cargo test --feature test-helpers to test it though.

That is pretty unergonomic. Can you explain the rationale?

@expenses
Copy link
Contributor Author

@rphmeier I've added rand back as a dev-dependency now, so it should just work.

@expenses
Copy link
Contributor Author

@rphmeier I need to test that.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@eb6ecd8). Click here to learn what that means.
The diff coverage is 98.05%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #104   +/-   ##
=========================================
  Coverage          ?   89.09%           
=========================================
  Files             ?       10           
  Lines             ?     3155           
  Branches          ?        0           
=========================================
  Hits              ?     2811           
  Misses            ?      344           
  Partials          ?        0
Impacted Files Coverage Δ
src/vote_graph.rs 97.33% <100%> (ø)
src/fuzz_helpers.rs 95.94% <97.48%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb6ecd8...7c4e99a. Read the comment docs.

@expenses
Copy link
Contributor Author

@rphmeier I think we're good to go here. Might be best to merge in #100 first if you're happy with that.

@rphmeier
Copy link
Contributor

Solve conflicts, then merge here. Thanks!

@rphmeier
Copy link
Contributor

We'll need to publish a new GRANDPA version; cc @andresilva

@rphmeier rphmeier merged commit 79bb39b into paritytech:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants