Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

[clone] Split runtime into devnet and mainnet#44

Merged
stiiifff merged 14 commits intomainfrom
dm-rebase
Jul 28, 2023
Merged

[clone] Split runtime into devnet and mainnet#44
stiiifff merged 14 commits intomainfrom
dm-rebase

Conversation

@weezy20
Copy link
Copy Markdown
Contributor

@weezy20 weezy20 commented Jul 8, 2023

This PR is a clone of #30 where we have rebased the changes on top of current main:HEAD Since this is a huge rebase and the other PR has been built without the many changes interim, it's best to keep this one separate, for nice and clean observation.

Issue #10

weezy20 added 4 commits July 8, 2023 17:36
- fix pallet-motion tests
- add short description for pallet-motion

- remove redundant import
fmt

use PARA_ID in chain_spec
@weezy20 weezy20 requested review from evilrobot-01, peterwht and stiiifff and removed request for peterwht July 8, 2023 13:01
@evilrobot-01
Copy link
Copy Markdown
Contributor

Minor thing, but do we need the word template in the runtime names? It would be easier for downstream teams if it were omitted and it's implied based on the repo name.

Then template users don't need to do anything to remove the template name when adopting, making it easier.

A counter argument is that a template perhaps provides no guarantees, so think it needs to be carefully considered.

@weezy20
Copy link
Copy Markdown
Contributor Author

weezy20 commented Jul 9, 2023

Minor thing, but do we need the word template in the runtime names? It would be easier for downstream teams if it were omitted and it's implied based on the repo name.

Template is supposed to be a placeholder. My take on this would be, given that it's a template we are free to choose whatever name we use for spec, impl strs and the runtime. Renaming things for a team would be as simple as replacing the entire string in the directory so I don't see renaming it bringing much convenience.

Comment thread runtime/common/Cargo.toml Outdated
Comment thread runtime/devnet/Cargo.toml Outdated
Comment thread runtime/common/Cargo.toml Outdated
@weezy20 weezy20 requested a review from stiiifff July 14, 2023 11:14
Comment thread node/src/command.rs Outdated
Comment thread runtime/devnet/src/lib.rs Outdated
@weezy20 weezy20 requested a review from stiiifff July 28, 2023 05:03
@stiiifff
Copy link
Copy Markdown
Contributor

LGTM !

@stiiifff stiiifff merged commit c7ff9f7 into main Jul 28, 2023
@stiiifff stiiifff deleted the dm-rebase branch July 28, 2023 14:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants