Merged
Conversation
Set --no-file-parallelism as otherwise vitest will fire all deployment at once, and that will mess up the nonce count
There was a problem hiding this comment.
Copilot reviewed 5 out of 8 changed files in this pull request and generated 2 comments.
Files not reviewed (3)
- eth-rpc/contracts/Flipper.sol: Language not supported
- eth-rpc/contracts/Tester.sol: Language not supported
- eth-rpc/package.json: Language not supported
Contributor
|
Hey PG - I gave the tests a run and theres one that seems to fail for me. Is it expected? |
Collaborator
Author
|
Ah yes we need to merge my polkadot-sdk pr first
…On Tue, Apr 8, 2025 at 3:53 PM Cameron Marshall ***@***.***> wrote:
Hey PG - I gave the tests a run and theres one that seems to fail for me
for me. Is it expected?
× eth-rpc > eth_getStorageAt works 5ms
→ expected '0x' to deeply equal '0x16000000000000000000000000000000000…'
—
Reply to this email directly, view it on GitHub
<#87 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD7HA7RIUAOHTMUJEB7EG32YPIEDAVCNFSM6AAAAAB2MF62NGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBWGUYTONZVHA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
*marshacb* left a comment (paritytech/evm-test-suite#87)
<#87 (comment)>
Hey PG - I gave the tests a run and theres one that seems to fail for me
for me. Is it expected?
× eth-rpc > eth_getStorageAt works 5ms
→ expected '0x' to deeply equal '0x16000000000000000000000000000000000…'
—
Reply to this email directly, view it on GitHub
<#87 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD7HA7RIUAOHTMUJEB7EG32YPIEDAVCNFSM6AAAAAB2MF62NGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBWGUYTONZVHA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
--
Wichtige Mitteilung
Diese Mitteilung wurde von Parity Technologies
Deutschland GmbH kommuniziert, eine im Handelsregister des Amtsgerichtes
Charlottenburg unter HRB 190583 B registrierte Gesellschaft mit
beschränkter Haftung (GmbH). Der Geschäftsführer der GmbH sind Frau Jessica
Grenier und Herr Antony Lias. Der registrierte Geschäftssitz ist Glogauer
Straße 6 in 10999 Berlin, Deutschland.
Diese Mitteilung enthält
Informationen welche vertraulich sind und welche eventuell die
Vertraulichkeit der Rechtsberatung ("Anwaltsgeheimnis") berühren. Sie ist
ausschließlich für den/die vorgesehenen Empfänger bestimmt. Wenn Sie nicht
der/die beabsichtigte(n) Empfänger sind, benachrichtigen Sie bitte
***@***.*** ***@***.***> und löschen Sie diese Nachricht
sofort.
Unsere Datenschutzrichtlinie, einschließlich die Art und den
Umfang von personenbezogenen Daten, die wir erfassen, wie wir diese Daten
erfassen und verarbeiten, an wen wir sie in Bezug auf die von uns
angebotenen Dienste weitergeben dürfen, sowie bestimmte Rechte und
Optionen, die Sie in dieser Hinsicht haben, finden Sie unter:
https://www.parity.io/privacy/ <https://www.parity.io/privacy/>
|
github-merge-queue bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Apr 22, 2025
Refactor eth-rpc - Get rid of the in memory-cache, we can just store receipts logs into sqlite, and use in-memory db for non archive node. - Track both best and finalized blocks so that we can properly index transaction receipts in case of a relay chain re-org. - Keep reference to the latest finalized block so that we can use that for queries that use the `finalized` block tag - use `--index-last-n-blocks` cli parameter to re-index the last n block when the server start - Fix issue related to gas estimate calculation for EIP1559 transaction types tested changes with paritytech/evm-test-suite#87 fix paritytech/contract-issues#35 paritytech/contract-issues#33 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-merge-queue bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Apr 22, 2025
Refactor eth-rpc - Get rid of the in memory-cache, we can just store receipts logs into sqlite, and use in-memory db for non archive node. - Track both best and finalized blocks so that we can properly index transaction receipts in case of a relay chain re-org. - Keep reference to the latest finalized block so that we can use that for queries that use the `finalized` block tag - use `--index-last-n-blocks` cli parameter to re-index the last n block when the server start - Fix issue related to gas estimate calculation for EIP1559 transaction types tested changes with paritytech/evm-test-suite#87 fix paritytech/contract-issues#35 paritytech/contract-issues#33 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
castillax
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
May 12, 2025
Refactor eth-rpc - Get rid of the in memory-cache, we can just store receipts logs into sqlite, and use in-memory db for non archive node. - Track both best and finalized blocks so that we can properly index transaction receipts in case of a relay chain re-org. - Keep reference to the latest finalized block so that we can use that for queries that use the `finalized` block tag - use `--index-last-n-blocks` cli parameter to re-index the last n block when the server start - Fix issue related to gas estimate calculation for EIP1559 transaction types tested changes with paritytech/evm-test-suite#87 fix paritytech/contract-issues#35 paritytech/contract-issues#33 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: