Add Polkadot-specific test infrastructure for foreign assets#142
Merged
Add Polkadot-specific test infrastructure for foreign assets#142
Conversation
0xRVE
changed the title
github-merge-queue Bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Mar 23, 2026
#11460) ## Summary - Set `CallbackHandle = (pallet_assets_precompiles::ForeignAssetId<Runtime, Instance1>,)` in `pallet_assets::Config<Instance1>` for the kitchensink runtime. - Asset creation (`create`, `force_create`) now automatically populates a sequential foreign asset index mapping. Asset destruction cleans it up. ## Test plan - [x] Run [end-to-end tests](paritytech/evm-test-suite#142) (requires substrate-node, eth-rpc, node, cast) - [x] Revert CallbackHandle to `()` and confirm end-to-end tests fail Alternatively run this bashscript for testing: https://gist.github.com/0xRVE/99bbc5ec7fcabeb54e3b797bd4cc97c8 --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
pgherveou
reviewed
Mar 23, 2026
pgherveou
reviewed
Mar 24, 2026
pgherveou
reviewed
Mar 24, 2026
pgherveou
reviewed
Mar 24, 2026
pgherveou
reviewed
Mar 24, 2026
pgherveou
reviewed
Mar 26, 2026
…-work:paritytech/evm-test-suite into rve/enable-foreign-assets-in-kitchensink
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test:polkadottask that runs integration tests against the kitchensink nodeforeign-assets.test.tsverifying the ForeignAssetId CallbackHandle wiring:These tests are Polkadot-specific and do not compare against geth. They run via
a separate entry point (
polkadot-tests.ts) and do not affect existingtest:evm/test:pvm/test:gethtasks.Test plan
deno task test:polkadot— all 6 tests pass with CallbackHandle wireddeno task test:evmunaffected