Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@ordian
Copy link

@ordian ordian commented Nov 30, 2021

No description provided.

@ordian ordian requested review from a team and chevdor as code owners November 30, 2021 12:25
@bkchr
Copy link
Member

bkchr commented Nov 30, 2021

I'm against this. This will not solve any of the problems we have.

@ordian
Copy link
Author

ordian commented Nov 30, 2021

It should help until we fix the cumulus companion check (I agree it's not a proper solution to this problem) and also I don't see a harm in this.

@bkchr
Copy link
Member

bkchr commented Nov 30, 2021

Not really harm, just spam of the bot :P

@ordian
Copy link
Author

ordian commented Nov 30, 2021

Not really harm, just spam of the bot :P

Once a day at most I think, but can also lower this.

@chevdor
Copy link
Contributor

chevdor commented Nov 30, 2021

One issue I see with dependabot is that it keeps creating lots of noises as it opens PRs. Often those PRs sit here for more than one day.

It would be more efficient and less annoying to set a lower frequency such as weekly. It helps processing all those PRs at once and not have a new one showing up just after you dealt with all the open ones :)

I am however not certain it bring benefit over one person doing a round of updates "manually" and doing a single PR as required.

@ordian
Copy link
Author

ordian commented Nov 30, 2021

Note that this PR is only for one dependency (polkadot-primitives), which should update polkadot and substrate similar to #809.
My understanding is that it would be at most 1 PR per day, I can lower this to 1 PR per week, but the intention is to help with cumulus companion check for now.
Currently, many PRs are blocked on cumulus companion check just because of outdated Cargo.lock.

@drahnr
Copy link
Contributor

drahnr commented Nov 30, 2021

This would indeed help the polkadot repo quite a bit, right now ~30 to 40% of our PRs don't work with bot merge due cumulus check failing.

@ordian ordian closed this Dec 2, 2021
@ordian ordian deleted the ao-dependabot-polkadot branch December 2, 2021 13:20
@ordian
Copy link
Author

ordian commented Dec 2, 2021

closing in favor of paritytech/polkadot#4451

@ordian ordian mentioned this pull request Jan 3, 2022
yrong added a commit to Snowfork/cumulus that referenced this pull request Apr 27, 2023
yrong added a commit to Snowfork/cumulus that referenced this pull request May 10, 2023
* Const value for pruning

* Some polish
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants