This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Fix Benchmarks for Statemine-V4 release#639
Merged
NachoPal merged 10 commits intorelease-statemine-v4from Oct 4, 2021
Merged
Conversation
apopiak
approved these changes
Oct 4, 2021
…tech/cumulus into nacho-statemine-v4-fix-benchmarks
apopiak
added a commit
that referenced
this pull request
Oct 8, 2021
* register validators * register_as_candidate & leave_intent fixed * new_session benchmark fixed * intent_leave_modified * clean up * clean up * benchmark script updated * update cargo.lock * done Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
apopiak
added a commit
that referenced
this pull request
Oct 11, 2021
* bump runtime spec version * remove applied runtime migrations * bump transaction_version necessary because of extrinsic API changes to pallet-xcm paritytech/polkadot#3693 * Fix Benchmarks for Statemine-V4 release (#639) * register validators * register_as_candidate & leave_intent fixed * new_session benchmark fixed * intent_leave_modified * clean up * clean up * benchmark script updated * update cargo.lock * done Co-authored-by: Alexander Popiak <alexander.popiak@parity.io> * Version bump (#648) * Version bump fix #646 * Revert "Version bump" This reverts commit 07517e0. * Bump polkadot-collator version * Update polkadot-parachains/Cargo.toml Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update deps * Bump version to 4.0.0 Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * cargo toml fix * update deps and remove DisabledValidatorThreshold * cargo +nightly fmt * fix compile error * fix client tests after Polkadot update Co-authored-by: Ignacio Palacios <ignacio.palacios.santos@gmail.com> Co-authored-by: Chevdor <chevdor@users.noreply.github.com> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #627
Issue was introduced in: #498
Benchmarks stopped working because of this: https://github.com/paritytech/cumulus/pull/498/files#diff-a0359a0add814d66aac74493f7e17aefdcee21d3de1ae592e97059082b6feedfR336-R337 and the introduction of
MinCandidates.I had to fix
register_as_candidate,leave_intentandnew_sessionbenchmarks.In addition, I updated the
benchmarks.shscript.It fixes: #588