This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Fix xcmp message processing condition.#510
Merged
bkchr merged 6 commits intoparitytech:masterfrom Jul 6, 2021
Merged
Conversation
Contributor
|
add a smoke test? |
Member
gavofyork
approved these changes
Jun 29, 2021
Member
|
A test would be nice. |
Contributor
Member
|
@apopiak no we should add a test here. If you can, add one, if not, I will do it later today |
shawntabrizi
approved these changes
Jul 6, 2021
Member
|
@apopiak please take a look and merge if you think it is okay |
apopiak
approved these changes
Jul 6, 2021
slumber
pushed a commit
that referenced
this pull request
Sep 1, 2021
* Fix xcmp message processing condition. * add a very simple test * Update Cargo.lock * remove comment * remove comment Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Alexander Popiak <alexander.popiak@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The messages processing loop shouldn't be entered again if there is no message left. Before this fix, calling
handle_xcmp_messageswith one message would panic.cumulus/pallets/xcmp-queue/src/lib.rs
Line 609 in 1bb5e2a
cumulus/pallets/xcmp-queue/src/lib.rs
Lines 522 to 528 in 1bb5e2a
Fixes: #473