Complete telemetry for parachain & relaychain #301
Conversation
cecton
changed the title
rococo-parachains/src/service.rs
Outdated
|
|
||
| let params = new_partial(¶chain_config)?; | ||
| let telemetry_span = params.other; | ||
| let _telemetry_span_entered = telemetry_span.as_ref().map(|x| x.enter()); |
There was a problem hiding this comment.
Why do we need to do this here manually?
There was a problem hiding this comment.
I need to investigate but I think there is something in a function somewhere below that reports something to the telemetry.
I know it's vague and it's probably not needed for the telemetry to work. I just wanted to make sure we don't miss a telemetry message at all.
There was a problem hiding this comment.
Please investigate this. The problem here is that this isn't any code that is reusable, so people would need to copy this.
There was a problem hiding this comment.
You're right!! I missed that
cecton
force-pushed
the
cecton-complete-telemetry
branch
from
36c7dfb to
4126e0e
Compare
|
@bkchr this is also ready for review |
|
@cecton fails to compile :P |
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
Please do not import Encode from sp_core. Otherwise it looks good.
Closes #149
Closes #154