This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
set-metadata is a safe call #2952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilescope
added
T6-XCM
gilescope
removed
the
T1-runtime
joepetrowski
approved these changes
Jul 29, 2023
gilescope
added
T1-runtime
NachoPal
approved these changes
Aug 2, 2023
bkontur
approved these changes
Aug 4, 2023
rphmeier
approved these changes
Aug 4, 2023
KiChjang
approved these changes
Aug 5, 2023
|
bot merge |
1 similar comment
|
bot merge |
|
Error: Github API says #2952 is not mergeable |
1 similar comment
|
Error: Github API says #2952 is not mergeable |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bit of inconsistency in the diffs, most allow set-metadata, some don't. Set metadata is bounded by
StringLengthso it should be safe to call. This PR removes these inconsistencies to allow it everywhere.