Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix Unused Variable for PoolAssets Benchmark #2808

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Fix Unused Variable for PoolAssets Benchmark #2808

merged 1 commit into from
Jul 3, 2023

Conversation

joepetrowski
Copy link
Contributor

Fixes compiler warning:

warning: type alias `Pool` is never used
    --> parachains/runtimes/assets/asset-hub-westend/src/lib.rs:1169:9
     |
1169 |             type Pool = pallet_assets::Pallet::<Runtime, PoolAssetsInstance>;
     |                  ^^^^
     |
     = note: `#[warn(dead_code)]` on by default

warning: type alias `Pool` is never used
    --> parachains/runtimes/assets/asset-hub-westend/src/lib.rs:1307:9
     |
1307 |             type Pool = pallet_assets::Pallet::<Runtime, PoolAssetsInstance>;
     |                  ^^^^

@joepetrowski joepetrowski added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. T1-runtime This PR/Issue is related to the topic “runtime”. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jul 3, 2023
@joepetrowski joepetrowski requested review from gilescope and bkontur July 3, 2023 05:40
@bkchr bkchr merged commit 28f6bd7 into master Jul 3, 2023
@bkchr bkchr deleted the joe-fix-unused-pool-var branch July 3, 2023 09:45
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@JesseAbram JesseAbram mentioned this pull request Oct 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@gilescope gilescope gilescope approved these changes

@bkontur bkontur Awaiting requested review from bkontur

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joepetrowski @gilescope @bkchr