This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 371
Remove CanAuthorWith trait #1609
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CanAuthotWith trait removed. Also all dependencies, parameters, type paramers were removed. This is related to removal of native runtime.
cargo update -p polkadot-runtime-common
davxy
reviewed
Sep 12, 2022
Cargo.lock
Outdated
| @@ -451,7 +451,7 @@ dependencies = [ | |||
| [[package]] | |||
| name = "beefy-gadget" | |||
| version = "4.0.0-dev" | |||
| source = "git+https://github.com/paritytech/substrate?branch=master#26193945883c773f2f14f976da3c3bd11dc0eb79" | |||
| source = "git+https://github.com/paritytech/substrate?branch=master#7de3d7870f63a525977fd4e91cda16039e7b1d60" | |||
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you should rollback Cargo.lock and let the bot eventually update it when your Substrate PR is merged
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged master, and rolled back changes in Cargo.lock. I also triggered CI on substrate repo.
davxy
approved these changes
Sep 13, 2022
bkchr
approved these changes
Sep 13, 2022
|
Merge cancelled due to error. Error: Statuses failed for bdb0e8a |
Contributor
|
bot merge force |
|
Error: Required status check "continuous-integration/gitlab-test-linux-stable" is failing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A3-in_progress
Pull request is in progress. No review needed at this stage.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CanAuthotWith trait removed. Also all dependencies, parameters, type paramers were removed. This is related to removal of native runtime.
It is part of: paritytech/substrate#10966