This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Co #11456: Match statement fallthrough for benchmark commands
#1350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
A0-pleasereview
B0-silent
1 task
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
shawntabrizi
approved these changes
Jul 18, 2022
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Member
Author
|
bot merge |
|
Waiting for commit status. |
jiguantong
added a commit
to darwinia-network/darwinia-parachain
that referenced
this pull request
Sep 21, 2022
aurexav
added a commit
to darwinia-network/darwinia-parachain
that referenced
this pull request
Oct 12, 2022
* Anchor polkadot-v0.9.27 * Companion for paritytech/cumulus#1436 * Companion for paritytech/cumulus#1421 * Companion for paritytech/cumulus#1350 * Companion for paritytech/cumulus#1456 * Use messages-substrate prepare-polkadot-v0.9.27 for debug * Companion for darwinia-network/darwinia-messages-substrate#169 * Companion for darwinia-network/darwinia-messages-substrate#192 * Companion for darwinia-network/darwinia-messages-substrate#186 * Companion for darwinia-network/darwinia-messages-substrate#201 * Missing part companion for darwinia-network/darwinia-messages-substrate#169 * format * replace prepare-polkadot-v0.9.27 -> polkadot-v0.9.27 * use `PANGOLIN_PANGOLIN_PARACHAIN_LANE` from `bridge_runtime_common` (#151) * format * Bump dependencies Co-authored-by: Xavier Lau <xavier@inv.cafe>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently each new benchmarking command in Substrate triggers a change in Cumulus.
After this MR there is no need for a hard-companion anymore, since the default behaviour will return an error for "unsupported command".
Useful for paritytech/substrate#11456 since adding the
benchmark extrinsiclogic itself is highly runtime-dependent and (currently) not useful to have.