Updated weights for v900 release#1193
Conversation
remark_with_event has flipped to weight 0 on polkadot.
|
I can not find either a explanation for the extra read/writes for |
|
If you look at that url you can see that not all the weights files were updated. |
What do you mean? we are running the benchmarks for 11 pallets and I see in the PR that 33 files were changed, which make sense since we have 3 runtimes. |
|
So talking with Oliver, the not updated weights files basically have been fixed since year dot. The Oliver has kindly documented this all here: paritytech/substrate#11246 So I think there's no reason not to merge what we have and look forward to an expanded benchmarking scope for next release. |
|
batch_all has db read and write added. - we note that polkadot had the same added and was approved: https://github.com/paritytech/polkadot/blob/1d6660fc484bcad9756424708de4c3271e2eada5/runtime/polkadot/src/weights/pallet_utility.rs#L60 |
|
For posterity: |
notable changes:
batch_all has db read and write added. (There don't seem to be any changes to the utilities pallet in substrate).
remark_with_event has flipped to weight 0 on polkadot. (I'm fine with this as the extrinsic length is where the remark fee is charged.)
Everything else looks pretty tight - not much change from last time.