Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@joao-paulo-parity
Copy link
Contributor

⚠️ The inclusion of pr-custom-review.yml does not incur immediate application of its rules. This file will start to be used only after the GitHub workflow is added, as demonstrated by https://github.com/paritytech/substrate/pull/10951/files.


This PR implements the requirements discussed in paritytech/pr-custom-review#67. Feel free to comment there for any disagreements.

The missing requirement is implemented as a built-in check, therefore it should not be included here.

Creates .github/pr-custom-review.yml

@joao-paulo-parity joao-paulo-parity added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low 📌 labels Apr 5, 2022
@joao-paulo-parity joao-paulo-parity requested review from a team and chevdor as code owners April 5, 2022 13:57
@joao-paulo-parity joao-paulo-parity force-pushed the jp/pr-custom-review-config branch from 8466017 to 02e5433 Compare April 5, 2022 14:00
@sergejparity sergejparity requested review from a team April 6, 2022 13:13
@TriplEight TriplEight merged commit c1641f7 into master Apr 7, 2022
@TriplEight TriplEight deleted the jp/pr-custom-review-config branch April 7, 2022 14:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants