This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Companion to "Updating scale to v3" #1013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wigy-opensource-developer
changed the title
KiChjang
reviewed
Feb 22, 2022
Contributor
KiChjang
left a comment
KiChjang
left a comment
There was a problem hiding this comment.
This is the repo where I expected changes to usages of decode, decode_all, decode_with_depth_limit and decode_and_advance_with_depth_limit because I remember coding them before, but I don't see any of those changes in this PR, is that intended?
KiChjang
added
A7-companion
B0-silent
Contributor
Author
|
I am so new to the cumulus codebase and using diener for 3 PRs on my machine that I wanted to rely on CI to tell me if the build or tests are broken. But the CI is now blocked on the rocksdb upgrade at the moment, so I did not get here yet. Also, CI does not run on draft PRs, so I could not use that to signal this is not ready yet. I will do a manual search for the usages and commit a fix. |
added 2 commits
February 25, 2022 13:49
ordian
approved these changes
Feb 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to paritytech/substrate#10825