Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

feat: ink contract events #843

Merged
merged 20 commits into from
Apr 7, 2023
Merged

feat: ink contract events #843

merged 20 commits into from
Apr 7, 2023

Conversation

kratico
Copy link
Contributor

@kratico kratico commented Apr 4, 2023 •
edited
Loading

resolve #570 #845

  • Implement Ink contract emitted event decoding.
  • Upgrade to Ink v4 metadata
  • Change example contract to Ink ERC-20 example

kratico
kratico commented Apr 4, 2023
View reviewed changes
patterns/ink/events.ts Outdated Show resolved Hide resolved
kratico
kratico commented Apr 4, 2023
View reviewed changes
examples/ink/interact.eg.ts Outdated Show resolved Hide resolved
@kratico kratico marked this pull request as ready for review April 5, 2023 20:08
harrysolovay
harrysolovay suggested changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@harrysolovay harrysolovay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep consistency between $event and our error-related code, let's move the error codec into the InkMetadataRune, with the name $error.

kratico
kratico commented Apr 5, 2023
View reviewed changes
patterns/ink/InkRune.ts Outdated Show resolved Hide resolved
patterns/ink/InkRune.ts Outdated Show resolved Hide resolved
patterns/ink/InkMetadata.ts Show resolved Hide resolved
examples/ink/interact.eg.ts Outdated Show resolved Hide resolved
scale_info/overrides/overrides.ts Show resolved Hide resolved
patterns/ink/InkRune.ts Outdated Show resolved Hide resolved
patterns/ink/InkMetadataRune.ts Outdated Show resolved Hide resolved
@kratico kratico requested a review from harrysolovay April 5, 2023 21:57
kratico and others added 17 commits April 7, 2023 10:10
@harrysolovay harrysolovay enabled auto-merge April 7, 2023 16:17
@harrysolovay harrysolovay added this pull request to the merge queue Apr 7, 2023
@tjjfvi tjjfvi linked an issue Apr 7, 2023 that may be closed by this pull request
fix ink/interact.ts example #845
Closed
Merged via the queue into main with commit e044efb Apr 7, 2023
@harrysolovay harrysolovay deleted the feat/ink-events branch April 7, 2023 16:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harrysolovay harrysolovay harrysolovay left review comments

@tjjfvi tjjfvi tjjfvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix ink/interact.ts example ink contract event decoding
3 participants
@kratico @harrysolovay @tjjfvi