This repository has been archived by the owner on Sep 14, 2023. It is now read-only.
chore: move multisig account derivation util into pattern #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjjfvi
reviewed
Feb 20, 2023
| @@ -1,3 +1,4 @@ | |||
| export * as consensus from "./consensus/mod.ts" | |||
There was a problem hiding this comment.
I thought we got rid of this file
Comment on lines
+3
to
4
| export * from "./multisigAccountId.ts" | ||
| export * from "./MultisigRune.ts" |
There was a problem hiding this comment.
These should be colocated in one directory.
There was a problem hiding this comment.
I agree (exposed through patterns/multisig/mod.ts), but there are several other changes we should merge first (otherwise, we'll end up rewriting many imports).
tjjfvi
approved these changes
Feb 20, 2023
tjjfvi
force-pushed
the
move-multisig-addr-out-of-util
branch
from
7c13383 to
07654d1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
multisigAddressutil into the multisig pattern and renames it tomultisigAccountId.