This repository has been archived by the owner on Sep 14, 2023. It is now read-only.
chore: log util cleanup #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjjfvi
reviewed
Feb 15, 2023
harrysolovay
commented
Feb 15, 2023
tjjfvi
reviewed
Feb 15, 2023
fluent/ExtrinsicStatusRune.ts
Outdated
Comment on lines
21
to
24
| rune.into(ValueRune).map((value) => { | ||
| console.log(...prefix, value) | ||
| return value | ||
| }) |
There was a problem hiding this comment.
Actually, does the placement of the prefix rune list matter (inside the inner Runes vs. wrapping this and Rune.tuple(prefixes) in another Rune.tuple, and then mapping their results into the inner runes)?
There was a problem hiding this comment.
Really, the solution is to have a .trackMap or .metaMap or whatever on MetaRune and use that, but that can wait for later.
tjjfvi
approved these changes
Feb 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbgmethod onValueRuneaccept Runes as prefixslogStatusofextrinsicStatusRuneaccept Runes as prefixeslogmethod onValueRune(currently does same thing asdbg, which will be reworked upon resolution of rune: add support for DI via env #517)