Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

chore: remove branded type fluff #537

Merged
merged 1 commit into from
Feb 1, 2023
Merged

chore: remove branded type fluff #537

merged 1 commit into from
Feb 1, 2023

Conversation

harrysolovay
Copy link
Contributor

No description provided.

tjjfvi
tjjfvi reviewed Feb 1, 2023
View reviewed changes
Copy link
Contributor

@tjjfvi tjjfvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would go one step further and say remove Hex and Hash as well

@harrysolovay
Copy link
Contributor Author

Two thoughts:

  1. if we remove those types, let's do so after merging Rune (otherwise we'll unnecessarily touch upon many soon-to-be deleted effect files)
  2. Hex and Hash do offer some legibility gains... I suppose good tsdocs will ultimately cover this.

@harrysolovay harrysolovay force-pushed the remove_branded_hex_fluff branch from 291e206 to df5b42c Compare February 1, 2023 19:35
@harrysolovay harrysolovay merged commit bb30e38 into main Feb 1, 2023
@harrysolovay harrysolovay deleted the remove_branded_hex_fluff branch February 1, 2023 21:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tjjfvi tjjfvi tjjfvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harrysolovay @tjjfvi