Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

fix: ci & issue re deno upgrade #470

Merged
merged 2 commits into from
Dec 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check_secrets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Check Secrets
on:
push:
branches:
- master
- main
pull_request:
types:
- opened
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/deno_deploy.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
name: Deno Deploy
# Omitting pull requests here is intentional because it could be used as an
# attack vector from an outside source
on: push
jobs:
deploy:
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/fmt.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
name: Check Formatting
on: push
on:
- pull_request
- push
jobs:
check:
name: Check Formatting
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/spawn_examples.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
name: Spawn Examples
on:
workflow_dispatch:
push:
- workflow_dispatch
- push
- pull_request
jobs:
generate_example_paths:
name: Generate example paths
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/spellcheck.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
name: Spellcheck
on: push
on:
- pull_request
- push
jobs:
spellcheck:
runs-on: ubuntu-latest
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
name: Test
on: push
on:
ryanleecode marked this conversation as resolved.
Show resolved Hide resolved
- pull_request
- push
jobs:
test:
name: Run Tests
Expand Down
2 changes: 1 addition & 1 deletion rpc/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export class Client<
this.activeSubscriptions[id]!(e)
delete this.activeSubscriptions[id]
}
} else if (typeof e.id === "number") {
} else if (e.id !== undefined) {
const pendingCall = this.pendingCalls[e.id]
pendingCall?.resolve(e)
delete this.pendingCalls[e.id]
Expand Down