Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

feat: add zsh to dev container #464

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

ryanleecode
Copy link
Contributor

@ryanleecode ryanleecode commented Dec 20, 2022

Resolves #463

Description

Add dev as a new build stage in docker and install zsh in that stage; dev container file updated to point to dev stage. This ensures zsh is installed in dev builds and not production builds.

@ryanleecode ryanleecode force-pushed the feat/zsh-dev-container branch from 628753c to c2b8d13 Compare December 20, 2022 17:31
Copy link
Contributor

@kratico kratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ryanleecode ryanleecode deleted the feat/zsh-dev-container branch December 20, 2022 23:01
@ryanleecode ryanleecode restored the feat/zsh-dev-container branch December 20, 2022 23:08
@ryanleecode
Copy link
Contributor Author

oops i deleted the branch b4 merging

@ryanleecode ryanleecode reopened this Dec 20, 2022
@ryanleecode ryanleecode merged commit bf231e6 into paritytech:main Dec 20, 2022
@ryanleecode ryanleecode deleted the feat/zsh-dev-container branch December 20, 2022 23:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add zsh to docker file for dev container setup
2 participants