Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

docs: update links #457

Merged
merged 3 commits into from
Dec 5, 2022
Merged

docs: update links #457

merged 3 commits into from
Dec 5, 2022

Conversation

nuke-web3
Copy link
Contributor

@nuke-web3 nuke-web3 commented Dec 5, 2022

I see prettier is used in the .vscode setting elsewhere, use it in md too.

Metadata.test.ts.snap -- Found more links issues, but I think this is a generated file, so actually the runtime has the wrong links embedded in them? 😬
If so, can put in redirects on docs for these

```

Now let's fetch the metadata.
As an example, let's connect to Polkadot and fetch the chain's metadata for the present highest block.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true? Of is this somehow statically defined in capi?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure exactly what you mean. Can you please re-word this question?

Copy link
Contributor Author

@nuke-web3 nuke-web3 Dec 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I correct in assuming that the example here using Polkadot metadata is gathered at runtime from the network? So this actually is an RPC call that connects to some default node?

Or is everything here coming from the library itself, hard coded values?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I correct in assuming that the example here using Polkadot metadata is gathered at runtime from the network? So this actually is an RPC call that connects to some default node?

Correct

@nuke-web3
Copy link
Contributor Author

Perhaps I am failing CI as you instead wanted dprint to format md files?
dprint/dprint-vscode#39 trying now to get this working on my end 🤞

@nuke-web3 nuke-web3 changed the title Format .md with Prettier, update docs links docs: update links Dec 5, 2022
@harrysolovay
Copy link
Contributor

harrysolovay commented Dec 5, 2022

Correct: we use dprint for MD formatting.

Going to revert the snaphot. Aside from that, this looks great!

docs/Types.md Outdated Show resolved Hide resolved
@tjjfvi
Copy link
Contributor

tjjfvi commented Dec 5, 2022

Found more links issues, but I think this is a generated file, so actually the runtime has the wrong links embedded in them? 😬

That's generated off of a fixed version of the metadata, which was last refetched about a month ago, so it may very well be fixed in the latest runtime.

@nuke-web3
Copy link
Contributor Author

Perhaps a followup pr to update the metadat is in order: links in the docs with v3 are deprecated and redirect to the docs home/in almost all cases (not useful in most cases)

@nuke-web3 nuke-web3 requested a review from tjjfvi December 5, 2022 17:18
@nuke-web3 nuke-web3 merged commit fb3e7cd into main Dec 5, 2022
@nuke-web3 nuke-web3 deleted the NukeManDan-patch-1 branch December 5, 2022 22:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants