This repository has been archived by the owner on Sep 14, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
feat: rpc subscription refactor + returning results #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrysolovay
force-pushed
the
subscription-results
branch
2 times, most recently
from
November 19, 2022 21:12
367b2e8
to
6328dbf
Compare
tjjfvi
previously approved these changes
Nov 22, 2022
harrysolovay
force-pushed
the
subscription-results
branch
from
November 22, 2022 18:24
b67c2ba
to
e9ad916
Compare
kratico
previously approved these changes
Nov 22, 2022
kratico
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors RPC subscriptions / the Capi-wide listener interface such that one can return (and infer types from) results.
Previously...
With these changes...
The calling of a corresponding unsubscribe call method is now taken care of at the RPC level. This means we no longer need to return the subscription ID from RPC subscription effects, which allows us to return other values.
header
can be utilized as any other effect. This enables myriad new possibilities for modeling effects that observe and react to on-chain events.