Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

chore: misc effect cleanup #366

Merged
merged 4 commits into from
Nov 8, 2022
Merged

chore: misc effect cleanup #366

merged 4 commits into from
Nov 8, 2022

Conversation

harrysolovay
Copy link
Contributor

  • Got rid of duplicate effect
  • Got rid of unnecessary intermediate effects that would call specific codec encoding on specific values... now we just use encode/decode from the effects/core/scale.ts
  • Simplify some effect logic

@harrysolovay harrysolovay changed the title feat: runtime type assertion (via scale 0.9.0) and some effect cleanup chore: misc effect cleanup Nov 8, 2022
@harrysolovay harrysolovay marked this pull request as ready for review November 8, 2022 11:47
kratico
kratico approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@kratico kratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harrysolovay harrysolovay merged commit 2444a64 into main Nov 8, 2022
@harrysolovay harrysolovay deleted the use-scale-validation branch November 8, 2022 12:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kratico kratico kratico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harrysolovay @kratico