This repository has been archived by the owner on Sep 14, 2023. It is now read-only.
chore: use new RPC impl #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrysolovay
force-pushed
the
use-new-rpc
branch
2 times, most recently
from
9cbe341 to
d7c8967
Compare
harrysolovay
force-pushed
the
use-new-rpc
branch
from
43efdc4 to
e9d5d3e
Compare
kratico
reviewed
Nov 7, 2022
kratico
reviewed
Nov 7, 2022
kratico
reviewed
Nov 7, 2022
Co-authored-by: Matias Volpe <[email protected]>
kratico
previously approved these changes
Nov 7, 2022
kratico
previously approved these changes
Nov 7, 2022
kratico
approved these changes
Nov 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is (hopefully) one of that last large refactors that this codebase will see for some time. It utilizes the new RPC implementation of #341, in addition to a new version of zones. This refactor touches on many parts of the codebase, including testing utilities, tasks and of course effects.