This repository has been archived by the owner on Sep 14, 2023. It is now read-only.
feat: add xxhash wasm impl #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the old JS-based
xxhashimplementation with a WASM implementation (hand-written in WAT) that is, according to my benchmarks, 2×–100× faster (depending on how it's called).I added a
build:wasmtask, which transforms the WAT to WASM and copies the WASM into a TS file so as to be portable. This currently isn't run on CI or anything; as it only needs to be run when the WAT is updated (which should be relatively rare), I don't think this is essential. The task requires thewat2wasmtool from WABT.