This repository has been archived by the owner on Sep 14, 2023. It is now read-only.
Feat/rpc client #339
Merged
Feat/rpc client #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kratico
commented
Oct 28, 2022
Comment on lines
+72
to
+73
| const controller = new AbortController(); | ||
| const { signal } = controller; |
There was a problem hiding this comment.
with the AbortController we don't need a listener ref to remove the listener
kratico
commented
Oct 28, 2022
Comment on lines
+88
to
+98
| subscribeWithStop: ClientSubscribeWithStop<SendE, InternalE> = (message, createListenerCb) => { | ||
| const stop = () => { | ||
| delete this.pendingSubscriptions[message.id]; | ||
| const activeSubscriptionId = this.activeSubscriptionByMessageId[message.id]; | ||
| if (activeSubscriptionId) { | ||
| delete this.activeSubscriptions[activeSubscriptionId]; | ||
| } | ||
| }; | ||
| this.pendingSubscriptions[message.id] = createListenerCb(stop); | ||
| this.call(message); | ||
| }; |
There was a problem hiding this comment.
I'll rename this to subscribe and remove the method from line 83
kratico
commented
Oct 28, 2022
| this.activeSubscriptionByMessageId[e.id] = e.result; | ||
| } | ||
| delete this.pendingSubscriptions[e.id]; | ||
| } |
There was a problem hiding this comment.
there are many ifs here but for subscriptions we need to filter the initialization message so we can setup the listener for the actual subscription messages
kratico
commented
Oct 28, 2022
Comment on lines
+49
to
+54
| this.pendingSubscriptions[id]?.(e); | ||
| delete this.pendingSubscriptions[id]; | ||
| } | ||
| for (const id in this.activeSubscriptions) { | ||
| this.activeSubscriptions[id]?.(e); | ||
| delete this.activeSubscriptions[id]; |
There was a problem hiding this comment.
as long as the provider communicate any network error through the listeners, this will cover #245 for .call and .subscribe
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #
Description