This repository has been archived by the owner on Sep 14, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
feat: initial codegen #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested with Polkadot and the output looks correct. This is a great foundation: types, corresponding codecs (each explicitly typed to Would love to be able to use it through something like... deno run -A -r https://deno.land/x/capi/codegen.ts \
--src="wss://rpc.polkadot.io" \
--out="polkadot.ts" |
Open
harrysolovay
suggested changes
Oct 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very nice. Review is mostly nits––pretty much merge-ready.
This was referenced Oct 2, 2022
Closed
Co-authored-by: Harry Solovay <[email protected]>
harrysolovay
approved these changes
Oct 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @tjjfvi
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes progress towards #226
This cleans up the codegen code somewhat, though it's still not the prettiest. It also adds codegen for codecs, as well as initial stub codegen for pallets and their storage and calls.
This has only been minimally manually tested; automatic testing should be added, but we need to figure out the best approach for this.