This repository has been archived by the owner on Sep 14, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should we provide access to scope within the Rune system? (to enable the fluent API and patterns to decide how/when to cache-invalidate) import { $accountInfo, polkadotDev } from "@capi/polkadot-dev"
import { $, createDevUsers, Scope } from "capi"
const { alexa } = await createDevUsers()
const scope = new Scope()
const accountInfo = polkadotDev.System.Account.value(alexa.publicKey)
const a = await accountInfo.run(scope)
await delay(30000)
const b = await accountInfo.run(scope) // could be different now
await delay(30000)
const c = await accountInfo.run(scope) // could be different yet again How might one specify whether to rerun all occurrences, vs. idempotent per run, vs. per scope? |
For now, these kinds of questions of out of scope (pun intended) until the rest of the caching/memoization system is more settled. |
harrysolovay
previously approved these changes
Jun 15, 2023
harrysolovay
previously approved these changes
Jun 15, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jun 15, 2023
Co-authored-by: Harry Solovay <[email protected]>
Co-authored-by: Harry Solovay <[email protected]>
harrysolovay
approved these changes
Jun 15, 2023
kratico
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Jun 19, 2023
Closed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #978