Skip to content
This repository was archived by the owner on Jun 30, 2022. It is now read-only.

Fixing the bench-bot after substrate changes #91

Merged
joao-paulo-parity merged 1 commit into from
Apr 15, 2022
Merged

Fixing the bench-bot after substrate changes #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions bench.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ var SubstrateRuntimeBenchmarkConfigs = {
"--manifest-path=bin/node/cli/Cargo.toml",
"--",
"benchmark",
"pallet",
"--chain=dev",
"--steps=50",
"--repeat=20",
Expand All @@ -200,6 +201,7 @@ var SubstrateRuntimeBenchmarkConfigs = {
"--manifest-path=bin/node/cli/Cargo.toml",
"--",
"benchmark",
"pallet",
"--chain=dev",
"--steps=50",
"--repeat=20",
Expand Down Expand Up @@ -227,6 +229,7 @@ var PolkadotRuntimeBenchmarkConfigs = {
"--features=runtime-benchmarks",
"--",
"benchmark",
"pallet",
Copy link
Member

@ggwpez ggwpez Apr 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could also be needed in Lines 328 and 419. Although I dont know what they do 😆
PS: Yea looks like it should be added, otherwise we expose the other commands as well.

Copy link
Contributor

@joao-paulo-parity joao-paulo-parity Apr 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand those are custom "run whatever" commands which could have a different subcommand other than pallet, so I think they can stay as they are. I don't know who's using them anyhow, perhaps @shawntabrizi can shed some light here.

In any case that should not block this PR and we can add it later if necessary.

"--chain=polkadot-dev",
"--steps=50",
"--repeat=20",
Expand All @@ -246,6 +249,7 @@ var PolkadotRuntimeBenchmarkConfigs = {
"--features=runtime-benchmarks",
"--",
"benchmark",
"pallet",
"--chain=polkadot-dev",
"--steps=50",
"--repeat=20",
Expand All @@ -265,6 +269,7 @@ var PolkadotRuntimeBenchmarkConfigs = {
"--features=runtime-benchmarks",
"--",
"benchmark",
"pallet",
"--chain=kusama-dev",
"--steps=50",
"--repeat=20",
Expand All @@ -284,6 +289,7 @@ var PolkadotRuntimeBenchmarkConfigs = {
"--features=runtime-benchmarks",
"--",
"benchmark",
"pallet",
"--chain=westend-dev",
"--steps=50",
"--repeat=20",
Expand All @@ -303,6 +309,7 @@ var PolkadotRuntimeBenchmarkConfigs = {
"--features=runtime-benchmarks",
"--",
"benchmark",
"pallet",
"--chain=rococo-dev",
"--steps=50",
"--repeat=20",
Expand Down Expand Up @@ -330,6 +337,7 @@ var PolkadotXcmBenchmarkConfigs = {
"--features=runtime-benchmarks",
"--",
"benchmark",
"pallet",
"--chain=polkadot-dev",
"--steps=50",
"--repeat=20",
Expand All @@ -349,6 +357,7 @@ var PolkadotXcmBenchmarkConfigs = {
"--features=runtime-benchmarks",
"--",
"benchmark",
"pallet",
"--chain=polkadot-dev",
"--steps=50",
"--repeat=20",
Expand All @@ -369,6 +378,7 @@ var PolkadotXcmBenchmarkConfigs = {
"--features=runtime-benchmarks",
"--",
"benchmark",
"pallet",
"--chain=kusama-dev",
"--steps=50",
"--repeat=20",
Expand All @@ -389,6 +399,7 @@ var PolkadotXcmBenchmarkConfigs = {
"--features=runtime-benchmarks",
"--",
"benchmark",
"pallet",
"--chain=westend-dev",
"--steps=50",
"--repeat=20",
Expand Down