Merged
Conversation
dhirajs0
commented
Oct 27, 2025
| "authorize-upgrade": "node dist/zombie-bite-scripts/authorize_upgrade_ah.js", | ||
| "report-account-migration-status": "node dist/zombie-bite-scripts/report_account_migration_status.js", | ||
| "compare-state": "node dist/migration-tests/index.js", | ||
| "treasury-payouts": "node dist/migration-tests/treasury_payout/run_treasury_payouts.js", |
Contributor
Author
There was a problem hiding this comment.
added a script for this test.
x3c41a
reviewed
Oct 28, 2025
x3c41a
reviewed
Oct 29, 2025
Comment on lines
+83
to
+85
| (spendData?.status.isPending || spendData?.status.isFailed) && // pending or failed | ||
| spendData?.validFrom.toNumber() < currentRelayChainBlockNumber && // not early payout | ||
| spendData?.expireAt.toNumber() > currentRelayChainBlockNumber // not expired |
x3c41a
reviewed
Oct 29, 2025
x3c41a
reviewed
Oct 29, 2025
x3c41a
approved these changes
Oct 29, 2025
x3c41a
approved these changes
Oct 29, 2025
rockbmb
approved these changes
Oct 31, 2025
seadanda
reviewed
Nov 3, 2025
x3c41a
approved these changes
Nov 3, 2025
x3c41a
reviewed
Nov 6, 2025
Contributor
There was a problem hiding this comment.
Now, when ahm is over, we either need to merge it or close.
Leaving this one up to you
Contributor
Author
There was a problem hiding this comment.
Sure, let me resolve the merge conflict. Then we are good to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check treasury payouts which are already approved can be paid out post-migration
I have tested it locally for Kusama, the treasury payout call is working and the spend is getting processed.
It is kept in a separate directory as this test need to call an extrinsic and therefore need a locally forked network to modify it, compared to other tests that are only calling the rpc end point for fetching the storage data.
I have tested it on post migration snapshot from ci run Links , it was working on PAH as well.