reverse

.config/lychee.toml

@@ -30,6 +30,7 @@ exclude = [
 	"http://visitme/",
 	"https://visitme/",
 	# TODO meta issue: <https://github.com/paritytech/polkadot-sdk/issues/134>
+	"http://try-runtime.polkadot.io:443",
 	"https://docs.substrate.io/main-docs/build/custom-rpc/#public-rpcs",
 	"https://docs.substrate.io/rustdocs/latest/sp_api/macro.decl_runtime_apis.html",
 	"https://github.com/ipfs/js-ipfs-bitswap/blob/",

.config/review.polkacodes.yml

@@ -0,0 +1,10 @@
+rules:
+  - repo: polka-codes/prompts
+    path: review/preamble.md
+    branch: master
+  - repo: polka-codes/prompts
+    path: review/rust.md
+    branch: master
+  - repo: polka-codes/prompts
+    path: review/polkadot-sdk.md
+    branch: master

.github/actions/download-artifact-extract/action.yml

@@ -29,15 +29,45 @@ inputs:
 runs:
   using: "composite"
   steps:
-    - name: Download artifact
+    - name: Download artifact (attempt 1)
+      id: download_attempt_1
+      continue-on-error: true
+      uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+      with:
+        name: ${{ inputs.artifact-name }}
+        github-token: ${{ inputs.gh-token }}
+        run-id: ${{ inputs.run-id }}
+        path: ${{ inputs.extract-path }}
+
+    - name: Wait before retry 1
+      if: steps.download_attempt_1.outcome == 'failure'
       shell: bash
       run: |
-        echo "::group::📦 Downloading ${{ inputs.artifact-name }}"
-        echo "Artifact: ${{ inputs.artifact-name }}"
-        echo "Run ID: ${{ inputs.run-id }}"
-        echo "::endgroup::"
-
-    - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+        echo "::warning::Attempt 1 failed, retrying in 10s..."
+        sleep 10
+
+    - name: Download artifact (attempt 2)
+      id: download_attempt_2
+      if: steps.download_attempt_1.outcome == 'failure'
+      continue-on-error: true
+      uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+      with:
+        name: ${{ inputs.artifact-name }}
+        github-token: ${{ inputs.gh-token }}
+        run-id: ${{ inputs.run-id }}
+        path: ${{ inputs.extract-path }}
+
+    - name: Wait before retry 2
+      if: steps.download_attempt_2.outcome == 'failure'
+      shell: bash
+      run: |
+        echo "::warning::Attempt 2 failed, retrying in 20s..."
+        sleep 20
+
+    - name: Download artifact (attempt 3)
+      id: download_attempt_3
+      if: steps.download_attempt_2.outcome == 'failure'
+      uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
       with:
         name: ${{ inputs.artifact-name }}
         github-token: ${{ inputs.gh-token }}

.github/actions/get-solc/action.yml

@@ -34,4 +34,4 @@ runs:
       run: |
         echo "$(pwd)/solc" >> $GITHUB_PATH
         chmod +x solc/solc
-        xattr -x solc/solc
+        xattr -x solc/solc

.github/assets/revive-dev-node-polkavm-resolc.json

@@ -0,0 +1 @@
+{}

.github/assets/revive-dev-node-revm-solc.json

@@ -0,0 +1 @@
+{}

.github/scripts/check-zombienet-flaky-tests.sh

@@ -28,11 +28,11 @@ line_num=0
 
 while IFS= read -r line || [[ -n "$line" ]]; do
     line_num=$((line_num + 1))
-    
+
     if [[ -z "$line" ]]; then
         continue
     fi
-    
+
     # Parse format: test-name:issue-number
     if [[ ! "$line" =~ ^([^:]+):([0-9]+)$ ]]; then
         echo "❌ Line $line_num: Missing required issue number" >&2
@@ -42,26 +42,26 @@ while IFS= read -r line || [[ -n "$line" ]]; do
         has_errors=true
         continue
     fi
-    
+
     test_name="${BASH_REMATCH[1]}"
     issue_number="${BASH_REMATCH[2]}"
-    
+
     set +e
     issue_data=$(gh issue view "$issue_number" --json state,title,url 2>&1)
     gh_exit_code=$?
     set -e
-    
+
     if [[ $gh_exit_code -ne 0 ]]; then
         echo "❌ Line $line_num: Issue #$issue_number does not exist" >&2
         echo "   Test: $test_name" >&2
         has_errors=true
         continue
     fi
-    
+
     url=$(echo "$issue_data" | jq -r '.url')
     state=$(echo "$issue_data" | jq -r '.state')
     title=$(echo "$issue_data" | jq -r '.title')
-    
+
     # Check if it's an issue (not a PR) by verifying the URL contains '/issues/'
     if [[ ! "$url" =~ /issues/ ]]; then
         echo "❌ Line $line_num: #$issue_number is a Pull Request, not an Issue" >&2
@@ -71,16 +71,17 @@ while IFS= read -r line || [[ -n "$line" ]]; do
         has_errors=true
         continue
     fi
-    
+
     if [[ "$state" == "OPEN" ]]; then
         echo "✅ Line $line_num: $test_name -> Issue #$issue_number (open)"
     else
         echo "⚠️  Line $line_num: Issue #$issue_number is closed: '$title'" >&2
         echo "   Test: $test_name" >&2
         echo "   Consider removing this entry if the issue is resolved." >&2
     fi
-
-done < "$FLAKY_TESTS_FILE"
+
+# exclude empty lines and comments
+done < <(grep -vE '^\s*(#|$)' "$FLAKY_TESTS_FILE")
 
 echo
 

.github/scripts/cmd/cmd.py

@@ -7,8 +7,6 @@
 import _help
 import importlib.util
 import re
-import urllib.request
-import urllib.parse
 import difflib
 
 _HelpAction = _help._HelpAction
@@ -35,80 +33,40 @@ def setup_logging():
     open('/tmp/cmd/command_output.log', 'w')
 
 def fetch_repo_labels():
-    """Fetch current labels from the GitHub repository"""
-    try:
-        # Use GitHub API to get current labels
-        repo_owner = os.environ.get('GITHUB_REPOSITORY_OWNER', 'paritytech')
-        repo_name = os.environ.get('GITHUB_REPOSITORY', 'paritytech/polkadot-sdk').split('/')[-1]
-
-        api_url = f"https://api.github.com/repos/{repo_owner}/{repo_name}/labels?per_page=100"
-
-        # Add GitHub token if available for higher rate limits
-        headers = {'User-Agent': 'polkadot-sdk-cmd-bot'}
-        github_token = os.environ.get('GITHUB_TOKEN')
-        if github_token:
-            headers['Authorization'] = f'token {github_token}'
-
-        req = urllib.request.Request(api_url, headers=headers)
-
-        with urllib.request.urlopen(req) as response:
-            if response.getcode() == 200:
-                labels_data = json.loads(response.read().decode())
-                label_names = [label['name'] for label in labels_data]
-                print_and_log(f"Fetched {len(label_names)} labels from repository")
-                return label_names
-            else:
-                print_and_log(f"Failed to fetch labels: HTTP {response.getcode()}")
-                return None
-    except Exception as e:
-        print_and_log(f"Error fetching labels from repository: {e}")
+    """Fetch labels from environment (pre-fetched by workflow)"""
+    labels_json = os.environ.get('REPO_LABELS')
+    if labels_json:
+        try:
+            labels = json.loads(labels_json)
+            print_and_log(f"Loaded {len(labels)} labels from environment")
+            return labels
+        except json.JSONDecodeError as e:
+            print_and_log(f"Error parsing REPO_LABELS: {e}")
+            return None
+    else:
+        print_and_log("REPO_LABELS not set in environment")
         return None
 
 
 def check_pr_status(pr_number):
-    """Check if PR is merged or in merge queue"""
-    try:
-        # Get GitHub token from environment
-        github_token = os.environ.get('GITHUB_TOKEN')
-        if not github_token:
-            print_and_log("Error: GITHUB_TOKEN not set, cannot verify PR status")
-            return False  # Prevent labeling if we can't check status
-
-        repo_owner = os.environ.get('GITHUB_REPOSITORY_OWNER', 'paritytech')
-        repo_name = os.environ.get('GITHUB_REPOSITORY', 'paritytech/polkadot-sdk').split('/')[-1]
-        api_url = f"https://api.github.com/repos/{repo_owner}/{repo_name}/pulls/{pr_number}"
-
-        headers = {
-            'User-Agent': 'polkadot-sdk-cmd-bot',
-            'Authorization': f'token {github_token}',
-            'Accept': 'application/vnd.github.v3+json'
-        }
+    """Check PR status from environment (pre-fetched by workflow)"""
+    status_json = os.environ.get('PR_STATUS')
+    if not status_json:
+        print_and_log("Error: PR_STATUS not set, cannot verify PR status")
+        return False
 
-        req = urllib.request.Request(api_url, headers=headers)
-
-        with urllib.request.urlopen(req) as response:
-            if response.getcode() == 200:
-                data = json.loads(response.read().decode())
-
-                # Check if PR is merged
-                if data.get('merged', False):
-                    return False
-
-                # Check if PR is closed
-                if data.get('state') == 'closed':
-                    return False
-
-                # Check if PR is in merge queue (auto_merge enabled)
-                if data.get('auto_merge') is not None:
-                    return False
-
-                return True  # PR is open and not in merge queue
-            else:
-                print_and_log(f"Failed to fetch PR status: HTTP {response.getcode()}")
-                return False  # Prevent labeling if we can't check status
-    except Exception as e:
-        print_and_log(f"Error checking PR status: {e}")
-        return False  # Prevent labeling if we can't check status
+    try:
+        data = json.loads(status_json)
+        if data.get('merged', False):
+            return False
+        if data.get('state') == 'closed':
+            return False
+        if data.get('auto_merge', False):
+            return False
+        return True
+    except json.JSONDecodeError as e:
+        print_and_log(f"Error parsing PR_STATUS: {e}")
+        return False
 
 
 def find_closest_labels(invalid_label, valid_labels, max_suggestions=3, cutoff=0.6):
@@ -195,7 +153,7 @@ def auto_correct_labels(invalid_labels, valid_labels, auto_correct_threshold=0.8
  %(prog)s --runtime westend --fail-fast
 
  Does not output anything and cleans up the previous bot's & author command triggering comments in PR 
- %(prog)s --runtime westend rococo --pallet pallet_balances pallet_multisig --quiet --clean
+ %(prog)s --runtime westend --pallet pallet_balances pallet_multisig --quiet --clean
 '''
 
 parser_bench = subparsers.add_parser('bench', aliases=['bench-omni'], help='Runs benchmarks (frame omni bencher)', epilog=bench_example, formatter_class=argparse.RawDescriptionHelpFormatter)
@@ -310,7 +268,7 @@ def validate_and_auto_correct_labels(input_labels, valid_labels):
  %(prog)s T1-FRAME A2-substantial D3-involved
 
 Labels are fetched dynamically from the repository.
-Typos are auto-corrected when confidence is high (>80% similarity).
+Typos are auto-corrected when confidence is high (>80%% similarity).
 For label meanings, see: https://paritytech.github.io/labels/doc_polkadot-sdk.html
 '''
 
@@ -462,6 +420,7 @@ def main():
                     f"--no-storage-info --no-min-squares --no-median-slopes " \
                     f"{config['bench_flags']}"
                 print(f'-- Running: {cmd} \n')
+                os.environ['RUNTIME_LOG'] = 'off' # Turn off annoying logs during benchmarking
                 status = os.system(cmd)
 
                 if status != 0 and args.fail_fast:
@@ -545,7 +504,7 @@ def main():
             # Output labels as JSON for GitHub Action
             import json
             labels_output = {"labels": final_labels}
-            print(f"LABELS_JSON: {json.dumps(labels_output)}")
+            print_and_log(f"LABELS_JSON: {json.dumps(labels_output)}")
         except ValueError as e:
             print_and_log(f'❌ {e}')
 

.github/scripts/cmd/test_cmd.py

@@ -25,15 +25,6 @@
         "bench_features": "runtime-benchmarks",
         "bench_flags": "--flag3 --flag4"
     },
-    {
-        "name": "rococo",
-        "package": "rococo-runtime",
-        "path": "polkadot/runtime/rococo",
-        "header": "polkadot/file_header.txt",
-        "template": "polkadot/xcm/pallet-xcm-benchmarks/template.hbs",
-        "bench_features": "runtime-benchmarks",
-        "bench_flags": ""
-    },
     {
         "name": "asset-hub-westend",
         "package": "asset-hub-westend-runtime",
@@ -105,7 +96,6 @@ def test_bench_command_normal_execution_all_runtimes(self):
         self.mock_popen.return_value.read.side_effect = [
             "pallet_balances\npallet_staking\npallet_something\n",  # Output for dev runtime
             "pallet_balances\npallet_staking\npallet_something\n",  # Output for westend runtime
-            "pallet_staking\npallet_something\n",                   # Output for rococo runtime - no pallet here
             "pallet_balances\npallet_staking\npallet_something\n",  # Output for asset-hub-westend runtime
             "./substrate/frame/balances/Cargo.toml\n",                # Mock manifest path for dev -> pallet_balances
         ]
@@ -119,7 +109,6 @@ def test_bench_command_normal_execution_all_runtimes(self):
                 # Build calls
                 call("forklift cargo build -q -p kitchensink-runtime --profile production --features=runtime-benchmarks"),
                 call("forklift cargo build -q -p westend-runtime --profile production --features=runtime-benchmarks"),
-                call("forklift cargo build -q -p rococo-runtime --profile production --features=runtime-benchmarks"),
                 call("forklift cargo build -q -p asset-hub-westend-runtime --profile production --features=runtime-benchmarks"),
 
                 call(get_mock_bench_output(
@@ -137,7 +126,6 @@ def test_bench_command_normal_execution_all_runtimes(self):
                     header=os.path.abspath('polkadot/file_header.txt'),
                     bench_flags='--flag3 --flag4'
                 )),
-                # skips rococo benchmark
                 call(get_mock_bench_output(
                     runtime='asset-hub-westend',
                     pallets='pallet_balances',
@@ -230,7 +218,7 @@ def test_bench_command_normal_execution_xcm(self):
     def test_bench_command_two_runtimes_two_pallets(self):
         self.mock_parse_args.return_value = (argparse.Namespace(
             command='bench-omni',
-            runtime=['westend', 'rococo'],
+            runtime=['westend'],
             pallet=['pallet_balances', 'pallet_staking'],
             fail_fast=True,
             quiet=False,
@@ -239,7 +227,6 @@ def test_bench_command_two_runtimes_two_pallets(self):
         ), [])
         self.mock_popen.return_value.read.side_effect = [
             "pallet_staking\npallet_balances\n",  # Output for westend runtime
-            "pallet_staking\npallet_balances\n",  # Output for rococo runtime
         ]
 
         with patch('sys.exit') as mock_exit:
@@ -251,7 +238,6 @@ def test_bench_command_two_runtimes_two_pallets(self):
             expected_calls = [
                 # Build calls
                 call("forklift cargo build -q -p westend-runtime --profile production --features=runtime-benchmarks"),
-                call("forklift cargo build -q -p rococo-runtime --profile production --features=runtime-benchmarks"),
                 # Westend runtime calls
                 call(get_mock_bench_output(
                     runtime='westend',
@@ -267,21 +253,6 @@ def test_bench_command_two_runtimes_two_pallets(self):
                     header=header_path,
                     bench_flags='--flag3 --flag4'
                 )),
-                # Rococo runtime calls
-                call(get_mock_bench_output(
-                    runtime='rococo',
-                    pallets='pallet_staking',
-                    output_path='./polkadot/runtime/rococo/src/weights',
-                    header=header_path,
-                    bench_flags=''
-                )),
-                call(get_mock_bench_output(
-                    runtime='rococo',
-                    pallets='pallet_balances',
-                    output_path='./polkadot/runtime/rococo/src/weights',
-                    header=header_path,
-                    bench_flags=''
-                )),
             ]
             self.mock_system.assert_has_calls(expected_calls, any_order=True)