Skip to content

Add concurrency_suffix input to check-synchronization#12

Merged
BDevParity merged 1 commit intomainfrom
bd-add-concurrency-suffix
Apr 13, 2026
Merged

Add concurrency_suffix input to check-synchronization#12
BDevParity merged 1 commit intomainfrom
bd-add-concurrency-suffix

Conversation

@BDevParity
Copy link
Copy Markdown
Contributor

Summary

  • When multiple callers invoke check-synchronization in parallel within the same workflow run (e.g. from a combined publish workflow), they all resolve to the same concurrency group (repo-workflow-ref) and GitHub randomly cancels competing jobs.
  • Adds an optional concurrency_suffix input (default: empty) that callers can use to make the concurrency group unique per caller.
  • Backwards compatible — existing callers without the suffix get the same behavior as before.

Related: paritytech/polkadot-sdk#11703

Test plan

  • Existing callers without concurrency_suffix behave unchanged
  • Combined workflow callers passing unique suffixes no longer get random cancellations

Comment on lines -34 to +38
group: ${{ github.repository }}-${{ github.workflow }}-${{ github.ref }}
group: ${{ github.repository }}-${{ github.workflow }}-${{ github.ref }}${{ inputs.concurrency_suffix && format('-{0}', inputs.concurrency_suffix) || '' }}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did it like this so we do not have "-" at the end if suffix is "", just so future runs have identical concurency sufix as old ones if we do not set this field

BDevParity added a commit to paritytech/polkadot-sdk that referenced this pull request Apr 13, 2026
Each caller now passes a unique concurrency_suffix so parallel
check-synchronization invocations within the same workflow run
get distinct concurrency groups and don't cancel each other.

Also restores check-synchronization in release-reusable-publish-packages
with the concurrency suffix and inline org/killswitch guard.

Depends on: paritytech-release/sync-workflows#12
@EgorPopelyaev EgorPopelyaev self-requested a review April 13, 2026 14:06
When multiple callers invoke check-synchronization in parallel within
the same workflow run, they all resolve to the same concurrency group
and GitHub randomly cancels the competing jobs.

Adding an optional concurrency_suffix input lets callers provide a
unique value so their concurrency groups don't collide.
@BDevParity BDevParity force-pushed the bd-add-concurrency-suffix branch from 1868cd9 to b6d8f55 Compare April 13, 2026 14:08
@BDevParity BDevParity merged commit e179c95 into main Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants