Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blending decoupled cv #282

Merged
merged 3 commits into from
Nov 2, 2021
Merged

Fix blending decoupled cv #282

merged 3 commits into from
Nov 2, 2021

Conversation

kegl
Copy link
Contributor

@kegl kegl commented Jun 23, 2021

Porting the blending code to decoupled cv.

Copy link
Collaborator

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! So this file has a 100% code coverage, but it looks like this wasn't caught by the test suite.

It might be good to add a corresponding test, maybe not in this PR?

@kegl
Copy link
Contributor Author

kegl commented Jun 24, 2021

Yes, now that we can have nontrivial CVs, it would be good to have one among the starting kits (where folds are not pairs of indices but more complex objects).

@kegl kegl merged commit 7d07521 into paris-saclay-cds:master Nov 2, 2021
@kegl
Copy link
Contributor Author

kegl commented Nov 2, 2021

It might be good to add a corresponding test, maybe not in this PR?

We are planning to have a transfer learning workflow/score/Predictions, Predictions will have a set of source and target sets, at that point we will have a unit test for the nontrivial CV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants