Fix CI #592
Merged
Fix CI #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rth
commented
Feb 29, 2024
rth
commented
- Switch to fetching starting kit repos via HTTP rather than using git clone. As far as I can tell all those git clone in CI tests were triggering some github safety blocking the requests, leading the CI to hang.
- Fix for leap year on 29 february,
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #592 +/- ##
==========================================
- Coverage 93.51% 93.48% -0.04%
==========================================
Files 103 103
Lines 8976 8991 +15
==========================================
+ Hits 8394 8405 +11
- Misses 582 586 +4 ☔ View full report in Codecov by Sentry. |
This reverts commit f632800.
frcaud
reviewed
Mar 1, 2024
| @@ -172,8 +195,10 @@ def setup_ramp_kit_ramp_data( | |||
| 'it, you need to set "force=True".' | |||
| ) | |||
| shutil.rmtree(problem_data_path, ignore_errors=True) | |||
| ramp_data_url = "https://github.com/ramp-data/{}.git".format(problem_name) | |||
| Repo.clone_from(ramp_data_url, problem_data_path, **kwargs) | |||
| ramp_kit_url = ( | |||
There was a problem hiding this comment.
ramp_data_url here instead of ramp_kit_url ?
frcaud
reviewed
Mar 1, 2024
| ramp_kit_url = ( | ||
| f"https://github.com/ramp-data/{problem_name}/archive/refs/heads/master.zip" | ||
| ) | ||
| _fetch_github_repo(ramp_kit_url, problem_data_path) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.