-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert bagged scores to float #555
Conversation
…id DB error: can t adapt type numpy.int64
@rth could you review this change please ? |
Codecov Report
@@ Coverage Diff @@
## master #555 +/- ##
=======================================
Coverage 93.51% 93.51%
=======================================
Files 103 103
Lines 8922 8922
=======================================
Hits 8343 8343
Misses 579 579
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm it's a real bug and that fixes it.
@frcaud I think this deserves a changelog entry somewhere.
Thanks @frcaud ! |
@rth can you give us a hand to make a tiny minor release and update the server? I don't think I can do the release myself. maybe @glemaitre you have a minute otherwise to help here? 🙏 🙏 🙏 |
I can try to make the release now. |
❤
… Message ID: ***@***.***>
|
As far as I remember there were changes in this release requiring a DB migration. Or did you manage to update without it @glemaitre ? |
I made the release, I did not update the server :) If you could give a hand to upgrade the server because I am a bit rusty when it comes to DB migration since I did not do it in the last 2 years :). |
That works. I'll look into updating the server. |
pinging @agramfort since they started the data challenge and he could tell you the worker that are running currently |
I mean if it's just for this fix the easiest is to make a patch 0.8.2 release just with this change and update the server with that. For the DB migration, there will be some downtime and I would rather not do it if a data challenge tomorrow is depending on it :) |
OK, the 0.8.2 release with this fix is done and the server updated. I restarted the frontend and the schedulers I could find. |
Great ! Thanks @rth and @glemaitre |
In order to avoid DB error:
can't adapt type 'numpy.int64'