Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add teams /1: database definitions #545

Merged
merged 2 commits into from
Oct 15, 2021

Conversation

rth
Copy link
Collaborator

@rth rth commented Oct 13, 2021

This is part 1 of the effort to add teams discussed in #505 (comment) , and is a subset of changes from this PR

For now this updates changes the DB definitions, to make the review easier,

  • Removes the previous team link mechanism from the Team table (acceptor_id, initiator_id) which wasn't used
  • Add Team.is_individual field to distinguish between individual and non individual teams
  • Add a new UserTeam table which does many to many relationships between teams and users.

This would require a DB migration, but there is already a commit on main which would require it.

@pep8speaks
Copy link

pep8speaks commented Oct 13, 2021

Hello @rth! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-10-13 16:03:53 UTC

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #545 (d403151) into master (31919f7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
- Coverage   93.48%   93.47%   -0.01%     
==========================================
  Files         103      103              
  Lines        8882     8922      +40     
==========================================
+ Hits         8303     8340      +37     
- Misses        579      582       +3     
Impacted Files Coverage Δ
ramp-database/ramp_database/model/event.py 98.85% <100.00%> (ø)
ramp-database/ramp_database/model/submission.py 95.65% <100.00%> (+0.02%) ⬆️
ramp-database/ramp_database/model/team.py 100.00% <100.00%> (ø)
...mp-database/ramp_database/model/tests/test_team.py 100.00% <100.00%> (ø)
ramp-engine/ramp_engine/base.py 92.68% <0.00%> (-1.22%) ⬇️
ramp-engine/ramp_engine/dispatcher.py 96.42% <0.00%> (-1.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31919f7...d403151. Read the comment docs.

@agramfort
Copy link
Collaborator

@rth WIP or MRG?

@rth
Copy link
Collaborator Author

rth commented Oct 15, 2021

It's MRG. The idea is to split the large PR above into smaller chunks,

  • first one (current PR) to add the appropriate fields in the DB
  • then the functions to create / delete / join teams to ramp-database
  • and finally all the template/HTML rendering changes

to make it easier to review. The first two steps wouldn't affect the functionality of the ramp-board as it currently works. Well aside from the 1st one requiring a DB migration.

@agramfort agramfort merged commit a801033 into paris-saclay-cds:master Oct 15, 2021
@agramfort
Copy link
Collaborator

thx @rth

@rth rth deleted the add-teams-1 branch October 16, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants