ENH gets latest image if more than one #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame string contained in the name
|
not sure how to make tests for it though.... |
|
merge if you need to move on. We will know very quickly if it works :) |
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
==========================================
+ Coverage 93.54% 93.56% +0.01%
==========================================
Files 99 99
Lines 8496 8496
==========================================
+ Hits 7948 7949 +1
+ Misses 548 547 -1
Continue to review full report at Codecov.
|
tomMoral
approved these changes
Nov 24, 2020
tomMoral
approved these changes
Nov 24, 2020
… into launch_instance_update
|
Thanks @tomMoral and @agramfort |
maikia
added a commit
to maikia/ramp-board
that referenced
this pull request
Dec 3, 2020
* enable getting the newest image if there are more than one with the same string contained in the name * cleanup * cleanup * clean up * typo * update the tests
glemaitre
pushed a commit
that referenced
this pull request
Dec 3, 2020
* enable getting the newest image if there are more than one with the same string contained in the name * cleanup * cleanup * clean up * typo * update the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use case: when pipeline is used each next version of the image will have the name image_name_{date_time_of_creation}
this PR enables a worker to find all the images which include the name image_name in their name and to select the newest one.
This only works if the image_name is given in the config file. If the id of the image will be given the worker will always use the same image with that ID.