Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to credit #275

Merged
merged 18 commits into from
Nov 7, 2019
Merged

Redirect to credit #275

merged 18 commits into from
Nov 7, 2019

Conversation

kegl
Copy link
Collaborator

@kegl kegl commented Nov 7, 2019

Comments are in the other PR: #267

@codecov
Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #275 into acrobot_dev will decrease coverage by 0.18%.
The diff coverage is 83.73%.

Impacted file tree graph

@@               Coverage Diff               @@
##           acrobot_dev     #275      +/-   ##
===============================================
- Coverage        92.23%   92.04%   -0.19%     
===============================================
  Files               94       95       +1     
  Lines             6891     7055     +164     
===============================================
+ Hits              6356     6494     +138     
- Misses             535      561      +26
Impacted Files Coverage Δ
ramp-utils/ramp_utils/frontend.py 100% <ø> (ø) ⬆️
ramp-utils/ramp_utils/tests/test_frontend.py 100% <ø> (ø) ⬆️
...abase/ramp_database/tools/tests/test_submission.py 100% <100%> (ø) ⬆️
ramp-database/ramp_database/cli.py 98.49% <100%> (+0.12%) ⬆️
ramp-database/ramp_database/tests/test_cli.py 100% <100%> (ø) ⬆️
ramp-frontend/ramp_frontend/views/ramp.py 51.96% <25%> (-0.3%) ⬇️
...amp-database/ramp_database/tools/contributivity.py 82.6% <82.6%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c2cfe7...55aa11f. Read the comment docs.

@kegl
Copy link
Collaborator Author

kegl commented Nov 7, 2019

I will merge this into acrobot_dev. There is one outstanding issue: testing compute_historical_contributivity. For this we'll need another scored submission in test_submission somewhere before

compute_historical_contributivity(session_scope_module, 'iris_test')
. @glemaitre can you please do this and PR it into the acrobot_dev branch?

@kegl kegl merged commit 99d6107 into acrobot_dev Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant