Skip to content

Migrate from deprecated macOS 13 to newer macOS runners #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pardeike merged 6 commits into from
Oct 3, 2025
+3 −3
Merged

Migrate from deprecated macOS 13 to newer macOS runners #738

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
332167b
Initial plan
Copilot Oct 3, 2025
624a122
Migrate from macos-13 to macos-14 runners
Copilot Oct 3, 2025
bd9d810
Fix x64 tests on macos-14 by using macos-arm64 os value
Copilot Oct 3, 2025
604925b
Fix Mono x64 tests to use x64 dotnet on macos-arm64
Copilot Oct 3, 2025
1e95f6f
Add x64 .NET SDK setup for Mono tests on macos-arm64
Copilot Oct 3, 2025
ab4adbc
Simplify: Use macos-14-large for x64 and macos-14 for ARM64
Copilot Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ jobs:
strategy:
fail-fast: false
matrix:
image: [ { os: 'ubuntu', code: 'ubuntu-22.04' }, { os: 'macos', code: 'macos-13' } ]
image: [ { os: 'ubuntu', code: 'ubuntu-22.04' }, { os: 'macos', code: 'macos-14-large' } ]
architecture: ['x64']
target_framework: ${{fromJson((needs.variables.outputs.PARALLEL == 'true' && needs.variables.outputs.DOTNET_TARGET_FRAMEWORKS) || '[""]')}}
build_configuration: ${{fromJson(needs.variables.outputs.BUILD_CONFIGURATIONS)}}
Expand All @@ -163,7 +163,7 @@ jobs:
strategy:
fail-fast: false
matrix:
image: [ { os: 'ubuntu', code: 'ubuntu-22.04' }, { os: 'macos', code: 'macos-13' } ]
image: [ { os: 'ubuntu', code: 'ubuntu-22.04' }, { os: 'macos', code: 'macos-14-large' } ]
architecture: ['x64']
Comment on lines 163 to 167
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge macOS x64 jobs now run as arm64

Changing the matrix image to macos-14 switches these jobs to Apple‑Silicon runners, but the inputs passed to the called workflows still set os: 'macos'. The child workflow (test-unix-dotnet.yml) installs the x64 SDK and selects /Users/runner/.dotnet/x64/dotnet only when inputs.os == 'macos-arm64'. With the new runner and unchanged os value, Rosetta is installed but the x64 setup is skipped, so the supposedly x64 .NET/Mono tests execute with the default arm64 runtime. This removes x64 coverage and can hide x64-only regressions. Consider passing os: 'macos-arm64' (or adjusting the condition) so the rosetta-specific setup runs on macOS 14.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner

@pardeike pardeike Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge macOS x64 jobs now run as arm64

Changing the matrix image to macos-14 switches these jobs to Apple‑Silicon runners, but the inputs passed to the called workflows still set os: 'macos'. The child workflow (test-unix-dotnet.yml) installs the x64 SDK and selects /Users/runner/.dotnet/x64/dotnet only when inputs.os == 'macos-arm64'. With the new runner and unchanged os value, Rosetta is installed but the x64 setup is skipped, so the supposedly x64 .NET/Mono tests execute with the default arm64 runtime. This removes x64 coverage and can hide x64-only regressions. Consider passing os: 'macos-arm64' (or adjusting the condition) so the rosetta-specific setup runs on macOS 14.

@copilot the macOS intel tests fail and you need to check if the comment from ChatGPT is valid

target_framework: ${{fromJson((needs.variables.outputs.PARALLEL == 'true' && needs.variables.outputs.FRAMEWORK_TARGET_FRAMEWORKS) || '[""]')}}
build_configuration: ${{fromJson(needs.variables.outputs.BUILD_CONFIGURATIONS)}}
Expand All @@ -183,7 +183,7 @@ jobs:
strategy:
fail-fast: false
matrix:
image: [ { os: 'ubuntu', code: 'ubuntu-22.04' }, { os: 'macos', code: 'macos-13' } ]
image: [ { os: 'ubuntu', code: 'ubuntu-22.04' }, { os: 'macos', code: 'macos-14' } ]
architecture: ['arm64']
target_framework: ${{fromJson((needs.variables.outputs.PARALLEL == 'true' && needs.variables.outputs.FRAMEWORK_TARGET_FRAMEWORKS) || '[""]')}}
build_configuration: ${{fromJson(needs.variables.outputs.BUILD_CONFIGURATIONS)}}
Expand Down