Skip to content

Fix a bunch of Mono.Cecil's API being public in the merged version#708

Merged
pardeike merged 1 commit intopardeike:masterfrom
Banane9:fix/leaked-cecil-API
Aug 21, 2025
Merged

Fix a bunch of Mono.Cecil's API being public in the merged version#708
pardeike merged 1 commit intopardeike:masterfrom
Banane9:fix/leaked-cecil-API

Conversation

@Banane9
Copy link
Copy Markdown
Contributor

@Banane9 Banane9 commented Aug 21, 2025

Start of discussion on the discord server: https://discord.com/channels/131466550938042369/361891646742462467/1407848296734789822

Cecil's VariableDefinition was public in one FileLog method, so making that internal is the easiest fix.
The method could also be moved from FileLog to the MethodCreatorTools class, which is the only one that uses it, though.

With this change, everything Cecil is internal again:
Screenshot of ILSpy with the merged 0Harmony.dll selected showing that all Cecil types are internal.

@pardeike pardeike merged commit 0c42ebb into pardeike:master Aug 21, 2025
30 checks passed
@Banane9 Banane9 deleted the fix/leaked-cecil-API branch August 21, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants