Minor bug fix for exiting early when identifying requestGraph in loadGraphs #9437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeLane
approved these changes
Dec 13, 2023
irismoini
deleted the
imoini/minor-bug-fix-for-exiting-early-when-identifying-request-graph
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
The
loadGraphfunction sorts the files in the cache by size and modification time and then iterates through these files to identify therequestGraph. Because therequestGraphis written to the cache with thesetLargeBlobfunction, the file name always ends with '-0'. There's no need to waste time deserializing files that don't end with '-0' and checking to see if they are therequestGraph. However, there's currently a bug in this early stopping condition when identifying therequestGraph. This PR fixes that.💻 Examples
🚨 Test instructions
Commented out the break condition and logged the files that could possibly being deserialized if the requestGraph wasn't found on the first try. Previously files that did not end with '-0' where being deserialized, now only files ending with '-0' will be.
✔️ PR Todo