Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parcel query's inspect cache #9436

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

irismoini
Copy link
Contributor

@irismoini irismoini commented Dec 13, 2023

↪️ Pull Request

Currently Parcel-query's inspectCache() function fails with the error throw new Error('Table must have a consistent number of cells.'); This is because the size and deserialization time of the bundleGraph and assetGraph fail to be populated in cacheInfo due to a bug in getting the cacheInfo keys in loadLargeBlobRequestRequest. This PR fixes this bug and gets inspectCache working correctly.

💻 Examples

🚨 Test instructions

Ran Parcel-query with inspectCache on a .parcel-cache in Jira Frontend.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@irismoini irismoini self-assigned this Dec 13, 2023
@irismoini irismoini merged commit b035b82 into v2 Dec 13, 2023
15 of 16 checks passed
@irismoini irismoini deleted the imoini/P2X-1185-fix-parcel-querys-inspect-cache branch December 13, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants