Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Request Graph node types + request node requestTypes to numbers #9412

Merged
merged 9 commits into from
Nov 29, 2023

Conversation

gorakong
Copy link
Contributor

@gorakong gorakong commented Nov 28, 2023

↪️ Pull Request

💻 Examples

Example request node before:

{
  id: 'target_request:6a6450d10c82f7d2',
  type: 'request',
  requestType: 'target_request',
  invalidateReason: 0
}

After (type and requestTypes are now numbers):

{
  id: 'target_request:6a6450d10c82f7d2',
  type: 1,
  requestType: 5,
  invalidateReason: 0
}

Example file node before:

{ id: 'node_modules/fast-glob/out/utils/errno.js', type: 'file' }

After (type is now a number):

{ id: 'node_modules/fast-glob/out/utils/errno.js', type: 0 }

@gorakong gorakong changed the title [draft] Convert Request Graph node types + request node requestTypes to numbers Nov 28, 2023
@gorakong gorakong marked this pull request as ready for review November 29, 2023 20:07
Copy link
Contributor

@mattcompiles mattcompiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 🚀

@gorakong gorakong merged commit 273f94c into v2 Nov 29, 2023
14 of 16 checks passed
@gorakong gorakong deleted the gkong/reduce-cache branch November 29, 2023 21:13
@irismoini irismoini mentioned this pull request Dec 7, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants