Do not wrap duplicated assets when they are in different targets #9348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
commented
Oct 29, 2023
| // If the asset is available in multiple bundles in the same target, it's referenced. | ||
| if ( | ||
| this.getBundlesWithAsset(asset).filter( | ||
| b => b.target.distDir === bundle.target.distDir, |
There was a problem hiding this comment.
we should probably have a target.id at some point, but this is how the default bundler does it already.
mattcompiles
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression from #9109. When an asset is duplicated, that PR caused it to be wrapped so it gets deduplicated at runtime. However, if the duplication occurs in separate targets, this is not necessary. It resulted in
parcelRequiregetting added to library builds, causing downstream errors in poorly written bundlers trying to detect CJS usage (vercel/next.js#57649) (and also unnecessary global variables). The fix is to detect whether the duplication occurs within the same target.