Optimize Symbol Propagation (propagateSymbolsUp) #9337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mize-symbol-propagation
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. React HackerNews ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
|
mischnic
reviewed
Nov 6, 2023
mischnic
reviewed
Nov 6, 2023
|
Symbol propagation doesn't need the |
Co-authored-by: Niklas Mischkulnig <[email protected]>
…mize-symbol-propagation
…mize-symbol-propagation
…-bundler/parcel into gkong/optimize-symbol-propagation
mischnic
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This PR includes a post-order implementation of
dfsFast(an iterative DFS), and is used inpropagateSymbolsUp.Note:
skipChildren()is not included inpostOrderDfsFastsince it doesn't make sense to skip children in a traversal where we visit children before its parents.These changes result in ~2% performance increase in symbol propagation.