Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with cache and glob entries #9264

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Fix bug with cache and glob entries #9264

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61d8171
Fix bug with cache and glob entries
marcins Sep 22, 2023
0ba12b5
Merge branch 'v2' into mszczepanski/fix-glob-cache-bug
mattcompiles Oct 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions packages/core/core/src/RequestTracker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,15 +764,19 @@ export class RequestGraph extends ContentGraph<
let fileNameNodeId = this.getNodeIdByContentKey(
'file_name:' + basename,
);

// Find potential file nodes to be invalidated if this file name pattern matches
let above = this.getNodeIdsConnectedTo(
let above: Array<FileNode> = [];
for (const nodeId of this.getNodeIdsConnectedTo(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally had this code using .filter but Flow didn't like that, it didn't know that above only contained file nodes when passed in to invalidateFileNameNode on line 783.

fileNameNodeId,
requestGraphEdgeTypes.invalidated_by_create_above,
).map(nodeId => {
)) {
let node = nullthrows(this.getNode(nodeId));
invariant(node.type === 'file');
return node;
});
// these might also be `glob` nodes which get handled below, we only care about files here.
if (node.type === 'file') {
above.push(node);
}
}

if (above.length > 0) {
didInvalidate = true;
Expand Down
Loading