Support node: prefix for CJS dependencies
#9244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
approved these changes
Sep 13, 2023
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. |
ExE-Boss
reviewed
Sep 16, 2023
Comment on lines
+139
to
+141
| let builtin = specifier.strip_prefix("node:").unwrap_or(specifier); | ||
| if BUILTINS.contains(&builtin) { | ||
| (Specifier::Builtin(Cow::Borrowed(builtin)), None) |
There was a problem hiding this comment.
If specifier starts with "node:" then it should always be treated as a builtin, that was why Node introduced it in the first place (and also parity with ESM):
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8984
At least in current Node versions,
require("node:path")works fine, so I guess we should support it for CJS dependencies as well.This broke as part of the resolver usage for dev deps (see linked issue).