Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of globalThis polyfill #9199

Merged
merged 7 commits into from
Aug 22, 2023
Merged

Removal of globalThis polyfill #9199

merged 7 commits into from
Aug 22, 2023

Conversation

alshdavid
Copy link
Contributor

↪️ Pull Request

This PR removes the globalThis polyfill from the JS packager. The polyfill will be added at transform time in projects that specify a browser in their browser list that requires the polyfill.

The reason for this change is that the globalThis polyfill is included in every bundle, which can add up in larger projects.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@parcel-benchmark
Copy link

parcel-benchmark commented Aug 17, 2023 •
edited
Loading

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.69s +18.00ms
Cached 320.00ms +20.00ms ⚠️

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 269.00ms +14.00ms ⚠️
dist/modern/index.2cb8781a.js 1.02kb -132.00b 🚀 391.00ms +3.00ms

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 272.00ms +15.00ms ⚠️
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 274.00ms +16.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 273.00ms +15.00ms ⚠️
dist/modern/index.2cb8781a.js 1.02kb -132.00b 🚀 401.00ms +16.00ms

React HackerNews ✅

Timings

Description Time Difference
Cold 4.60s -35.00ms
Cached 440.00ms +2.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/index.js 460.80kb -132.00b 🚀 1.10s -21.00ms
dist/PermalinkedComment.b41e2791.js 4.07kb -134.00b 🚀 472.00ms +44.00ms ⚠️
dist/UserProfile.2a2fa310.js 1.51kb -134.00b 🚀 473.00ms +45.00ms ⚠️
dist/NotFound.13a965e5.js 399.00b -134.00b 🚀 472.00ms +44.00ms ⚠️
dist/logo.8dd07848.png 244.00b +0.00b 350.00ms +47.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/index.js 460.80kb -132.00b 🚀 1.13s +9.00ms
dist/PermalinkedComment.b41e2791.js 4.07kb -134.00b 🚀 415.00ms +16.00ms
dist/UserProfile.2a2fa310.js 1.51kb -134.00b 🚀 415.00ms +18.00ms
dist/NotFound.13a965e5.js 399.00b -134.00b 🚀 415.00ms +18.00ms

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 41.32s -2.19s 🚀
Cached 2.49s +7.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/index.ca7cdd59.js 3.79mb -132.00b 🚀 18.45s -1.33s 🚀
dist/pdfRenderer.488477b0.js 1.11mb -132.00b 🚀 13.70s -1.75s 🚀
dist/editorView.35ac73e7.js 619.90kb -134.00b 🚀 15.05s -1.39s 🚀
dist/refractor.c460668c.js 601.81kb -132.00b 🚀 12.65s -1.53s 🚀
dist/media-viewer.6b8adda1.js 537.45kb -134.00b 🚀 9.19s -2.27s 🚀
dist/popup.c282bed0.js 324.59kb -132.00b 🚀 12.65s -1.55s 🚀
dist/ConfigPanelFieldsLoader.54b2cecc.js 306.94kb -134.00b 🚀 9.20s -2.27s 🚀
dist/EmojiPickerComponent.1a5571cb.js 189.81kb -134.00b 🚀 12.64s -1.55s 🚀
dist/card.583a1f18.js 140.31kb -134.00b 🚀 9.19s -2.27s 🚀
dist/ConfigPanelFieldsLoader.d25d4efc.js 83.10kb -134.00b 🚀 12.61s -1.59s 🚀
dist/mobile-upload.35a8a8fb.js 66.63kb -132.00b 🚀 5.63s -717.00ms 🚀
dist/esm.1c9ef78b.js 63.49kb -134.00b 🚀 12.65s -1.55s 🚀
dist/ElementBrowser.8e866a0e.js 62.33kb -132.00b 🚀 9.20s -2.27s 🚀
dist/archive.a2217524.js 60.29kb -134.00b 🚀 12.65s +1.18s ⚠️
dist/esm.1a044825.js 59.85kb -134.00b 🚀 9.19s -2.27s 🚀
dist/component-lazy.1b33c14d.js 59.63kb -134.00b 🚀 6.66s -25.00ms
dist/component.bb2f7991.js 58.01kb -134.00b 🚀 5.63s -717.00ms 🚀
dist/DatePicker.9c23032b.js 47.98kb -134.00b 🚀 6.68s -780.00ms 🚀
dist/esm.3fa8c7de.js 39.56kb -134.00b 🚀 12.65s -1.55s 🚀
dist/Modal.ff929598.js 28.33kb -134.00b 🚀 5.63s -719.00ms 🚀
dist/DatePicker.a3ad9fca.js 25.15kb -134.00b 🚀 6.68s -780.00ms 🚀
dist/smartMediaEditor.0fdaaac3.js 21.89kb -134.00b 🚀 12.65s -1.55s 🚀
dist/esm.699bbabf.js 20.65kb -134.00b 🚀 12.65s -1.55s 🚀
dist/component.1c22aee9.js 18.81kb -134.00b 🚀 5.63s -720.00ms 🚀
dist/js.324be058.js 17.34kb -134.00b 🚀 5.63s -712.00ms 🚀
dist/ConfigPanelFieldsLoader.3cdf42ed.js 15.95kb -134.00b 🚀 9.19s -2.27s 🚀
dist/ui.f919792f.js 14.62kb -134.00b 🚀 9.19s -2.27s 🚀
dist/ConfigPanelFieldsLoader.0c1e88b7.js 13.78kb -134.00b 🚀 9.19s -2.27s 🚀
dist/dropzone.7e088531.js 13.61kb -134.00b 🚀 12.65s -1.55s 🚀
dist/pdfRenderer.187ba54d.js 12.21kb -132.00b 🚀 9.19s -2.27s 🚀
dist/dropzone.09d0b890.js 11.64kb -134.00b 🚀 12.65s -1.55s 🚀
dist/Toolbar.7b6f497e.js 9.53kb -134.00b 🚀 12.65s -1.55s 🚀
dist/clipboard.f5f3497c.js 8.07kb -134.00b 🚀 12.65s -1.55s 🚀
dist/mobile-upload.8bd7d5f3.js 7.99kb -134.00b 🚀 5.62s -716.00ms 🚀
dist/mobile-upload.41e1ddfc.js 7.99kb -134.00b 🚀 9.20s -2.27s 🚀
dist/mobile-upload.f2b8a53f.js 7.99kb -134.00b 🚀 9.20s -2.27s 🚀
dist/mobile-upload.40a8f0fb.js 7.99kb -134.00b 🚀 12.65s -1.55s 🚀
dist/index.runtime.50c92a63.js 7.42kb -132.00b 🚀 12.65s -1.55s 🚀
dist/browser.333a8efe.js 7.33kb -134.00b 🚀 12.65s -1.55s 🚀
dist/index.b16227d6.css 4.08kb +0.00b 12.66s -1.56s 🚀
dist/Modal.232b8600.js 4.00kb -134.00b 🚀 5.63s -720.00ms 🚀
dist/component.b84d6109.js 3.35kb -134.00b 🚀 5.63s -713.00ms 🚀
dist/media-viewer-analytics-error-boundary.c1511b0d.js 3.32kb -134.00b 🚀 12.65s +1.18s ⚠️
dist/media-picker-analytics-error-boundary.418c2c46.js 3.32kb -134.00b 🚀 12.65s -1.55s 🚀
dist/media-card-analytics-error-boundary.7d513b72.js 3.32kb -134.00b 🚀 12.65s -1.55s 🚀
dist/png-chunks-extract.c54842d7.js 3.19kb -134.00b 🚀 5.62s -694.00ms 🚀
dist/ru.896915b9.js 2.94kb -134.00b 🚀 9.20s +1.74s ⚠️
dist/uk.48c97550.js 2.89kb -134.00b 🚀 9.20s -2.27s 🚀
dist/codeViewerRenderer.f99075be.js 2.74kb -134.00b 🚀 9.19s -2.27s 🚀
dist/th.31044730.js 2.73kb -134.00b 🚀 9.20s -1.64s 🚀
dist/ResourcedEmojiComponent.1ec35575.js 2.60kb -134.00b 🚀 6.68s -779.00ms 🚀
dist/pl.5f36d63e.js 2.38kb -134.00b 🚀 6.68s -779.00ms 🚀
dist/cs.971d1d60.js 2.36kb -134.00b 🚀 6.68s -781.00ms 🚀
dist/de.6efbb375.js 2.30kb -134.00b 🚀 6.68s -780.00ms 🚀
dist/fr.af2c92ae.js 2.25kb -134.00b 🚀 6.68s -781.00ms 🚀
dist/es.23f0c164.js 2.25kb -134.00b 🚀 6.68s -780.00ms 🚀
dist/hu.8323f36b.js 2.23kb -134.00b 🚀 6.68s -781.00ms 🚀
dist/fi.7ed4b1b5.js 2.22kb -134.00b 🚀 6.68s -780.00ms 🚀
dist/ja.5653161c.js 2.22kb -134.00b 🚀 6.68s -781.00ms 🚀
dist/vi.d8dcb67a.js 2.22kb -134.00b 🚀 9.20s -2.27s 🚀
dist/pt_BR.eccfad73.js 2.19kb -134.00b 🚀 6.68s -779.00ms 🚀
dist/tr.46f26598.js 2.16kb -134.00b 🚀 9.20s -2.27s 🚀
dist/ko.2cf2bbda.js 2.11kb -134.00b 🚀 6.68s -781.00ms 🚀
dist/sv.13d93533.js 2.10kb -134.00b 🚀 9.20s -1.64s 🚀
dist/it.601d375a.js 2.10kb -134.00b 🚀 6.68s -781.00ms 🚀
dist/nb.b300dd3e.js 2.09kb -134.00b 🚀 6.68s -781.00ms 🚀
dist/date.7b2f9581.js 2.07kb -134.00b 🚀 5.91s -771.00ms 🚀
dist/da.21385cf2.js 2.07kb -134.00b 🚀 6.68s -781.00ms 🚀
dist/nl.3999ea58.js 2.07kb -134.00b 🚀 6.68s -779.00ms 🚀
dist/images.46c877f3.js 2.03kb -134.00b 🚀 5.91s -770.00ms 🚀
dist/zh_TW.afaf6222.js 1.98kb -134.00b 🚀 9.20s -2.27s 🚀
dist/zh.fcdc32bb.js 1.96kb -134.00b 🚀 9.19s -2.27s 🚀
dist/feedback.fd1f6260.js 1.89kb -134.00b 🚀 6.68s -766.00ms 🚀
dist/status.6f638b3d.js 1.80kb -134.00b 🚀 5.91s -770.00ms 🚀
dist/code.ef3dfa9c.js 1.69kb -134.00b 🚀 5.91s -771.00ms 🚀
dist/workerHasher.bfc999cd.js 1.69kb -134.00b 🚀 5.62s -694.00ms 🚀
dist/workerHasher.4b89e1de.js 1.69kb -134.00b 🚀 9.20s -2.27s 🚀
dist/workerHasher.06536d4e.js 1.69kb -134.00b 🚀 9.20s -2.27s 🚀
dist/workerHasher.dd4d2a38.js 1.69kb -134.00b 🚀 12.65s -1.55s 🚀
dist/workerHasher.eae92e5c.js 1.69kb -134.00b 🚀 12.65s -1.55s 🚀
dist/workerHasher.cfe5994f.js 1.69kb -134.00b 🚀 12.65s -1.55s 🚀
dist/list-number.35bc7f17.js 1.60kb -134.00b 🚀 5.91s -771.00ms 🚀
dist/heading6.974f167d.js 1.49kb -134.00b 🚀 6.68s -766.00ms 🚀
dist/16.87c743d1.js 1.48kb -134.00b 🚀 5.63s -715.00ms 🚀
dist/heading3.9ad47cbe.js 1.48kb -134.00b 🚀 5.91s -774.00ms 🚀
dist/16.dd50aef4.js 1.41kb -134.00b 🚀 5.63s -716.00ms 🚀
dist/link.542e87bf.js 1.41kb -134.00b 🚀 5.91s -771.00ms 🚀
dist/emoji.79757e2c.js 1.38kb -134.00b 🚀 5.91s -770.00ms 🚀
dist/heading5.023a8f1f.js 1.36kb -134.00b 🚀 6.68s -6.00ms
dist/expand.801fc3a0.js 1.31kb -134.00b 🚀 6.68s -766.00ms 🚀
dist/heading2.bffcdf12.js 1.30kb -134.00b 🚀 5.91s -771.00ms 🚀
dist/heading4.05995ed9.js 1.25kb -134.00b 🚀 6.66s -29.00ms
dist/mention.adafe481.js 1.21kb -134.00b 🚀 5.91s -771.00ms 🚀
dist/layout.40f6b132.js 1.17kb -134.00b 🚀 5.91s -770.00ms 🚀
dist/divider.616b37d8.js 1.17kb -134.00b 🚀 5.91s -770.00ms 🚀
dist/action.361730a6.js 1.15kb -134.00b 🚀 5.91s -771.00ms 🚀
dist/heading1.495af5dc.js 1.14kb -134.00b 🚀 5.91s -771.00ms 🚀
dist/16.9e7cc0d9.js 1.13kb -134.00b 🚀 5.63s -716.00ms 🚀
dist/list.c5ad55b6.js 1.11kb -134.00b 🚀 5.91s -771.00ms 🚀
dist/quote.235ab420.js 1.11kb -134.00b 🚀 5.91s -770.00ms 🚀
dist/decision.36a0b771.js 1.10kb -134.00b 🚀 5.91s -771.00ms 🚀
dist/16.8d078bd1.js 1.08kb -134.00b 🚀 5.63s -716.00ms 🚀
dist/16.bb53313d.js 1.08kb -134.00b 🚀 5.63s -716.00ms 🚀
dist/panel-warning.7e72ad42.js 1.07kb -134.00b 🚀 5.91s -770.00ms 🚀
dist/16.88e24f19.js 1.06kb -134.00b 🚀 5.63s -720.00ms 🚀
dist/16.0d8c3c9e.js 1.06kb -134.00b 🚀 5.91s -756.00ms 🚀
dist/table.389f0908.js 1.05kb -134.00b 🚀 5.91s -771.00ms 🚀
dist/16.db9c75f1.js 1.03kb -134.00b 🚀 5.63s -715.00ms 🚀
dist/panel.7cee1972.js 1017.00b -134.00b 🚀 5.91s -770.00ms 🚀
dist/panel-error.e46252ff.js 994.00b -134.00b 🚀 5.91s -771.00ms 🚀
dist/16.c0880b62.js 992.00b -134.00b 🚀 5.63s -715.00ms 🚀
dist/16.99296be0.js 964.00b -134.00b 🚀 5.63s -716.00ms 🚀
dist/16.c16ee42d.js 957.00b -134.00b 🚀 5.63s -720.00ms 🚀
dist/16.dcf139e7.js 951.00b -134.00b 🚀 5.91s -756.00ms 🚀
dist/panel-success.dbd2515b.js 935.00b -134.00b 🚀 5.91s -771.00ms 🚀
dist/panel-note.b6c94ff5.js 925.00b -134.00b 🚀 5.91s -771.00ms 🚀
dist/16.26c3d518.js 912.00b -134.00b 🚀 5.63s -715.00ms 🚀
dist/16.f76b9cae.js 906.00b -134.00b 🚀 5.63s -717.00ms 🚀
dist/16.fb327623.js 906.00b -134.00b 🚀 5.63s -717.00ms 🚀
dist/16.f2056258.js 905.00b -134.00b 🚀 5.63s -715.00ms 🚀
dist/16.4e7dec68.js 904.00b -134.00b 🚀 5.63s -716.00ms 🚀
dist/16.400116d9.js 903.00b -134.00b 🚀 5.63s -720.00ms 🚀
dist/16.f6395317.js 876.00b -134.00b 🚀 5.91s -757.00ms 🚀
dist/16.24326b68.js 855.00b -134.00b 🚀 5.63s -720.00ms 🚀
dist/16.0285f4b2.js 827.00b -134.00b 🚀 5.63s -715.00ms 🚀
dist/sk.101f1705.js 786.00b -134.00b 🚀 9.19s +1.73s ⚠️
dist/pt_PT.402f9c4e.js 765.00b -134.00b 🚀 6.69s -774.00ms 🚀
dist/et.69382942.js 763.00b -134.00b 🚀 6.68s -780.00ms 🚀
dist/simpleHasher.2403fa32.js 719.00b -134.00b 🚀 5.62s -695.00ms 🚀
dist/simpleHasher.8b7def87.js 719.00b -134.00b 🚀 9.20s -2.27s 🚀
dist/simpleHasher.38195df7.js 719.00b -134.00b 🚀 9.20s -2.27s 🚀
dist/simpleHasher.308c3a38.js 719.00b -134.00b 🚀 12.65s -1.55s 🚀
dist/simpleHasher.f29b9a84.js 719.00b -134.00b 🚀 12.65s -1.55s 🚀
dist/simpleHasher.d2c7eaf0.js 719.00b -134.00b 🚀 12.65s -1.55s 🚀
dist/is.5b945719.js 625.00b -134.00b 🚀 6.68s -781.00ms 🚀
dist/ro.a6eff34a.js 612.00b -134.00b 🚀 6.69s -774.00ms 🚀
dist/en_GB.61f7112a.js 602.00b -134.00b 🚀 6.68s -780.00ms 🚀
dist/en.41261459.js 599.00b -134.00b 🚀 6.68s -781.00ms 🚀
dist/index.html 248.00b +0.00b 12.62s +6.31s ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/index.ca7cdd59.js 3.79mb -132.00b 🚀 18.70s -305.00ms
dist/pdfRenderer.488477b0.js 1.11mb -132.00b 🚀 13.81s -836.00ms 🚀
dist/editorView.35ac73e7.js 619.90kb -134.00b 🚀 15.01s -703.00ms
dist/refractor.c460668c.js 601.81kb -132.00b 🚀 12.36s -996.00ms 🚀
dist/media-viewer.6b8adda1.js 537.45kb -134.00b 🚀 9.21s -4.15s 🚀
dist/popup.c282bed0.js 324.59kb -132.00b 🚀 12.36s -999.00ms 🚀
dist/ConfigPanelFieldsLoader.54b2cecc.js 306.94kb -134.00b 🚀 9.22s -257.00ms
dist/EmojiPickerComponent.1a5571cb.js 189.81kb -134.00b 🚀 12.35s -1.01s 🚀
dist/card.583a1f18.js 140.31kb -134.00b 🚀 9.22s -254.00ms
dist/ConfigPanelFieldsLoader.d25d4efc.js 83.10kb -134.00b 🚀 12.35s -1.01s 🚀
dist/mobile-upload.35a8a8fb.js 66.63kb -132.00b 🚀 5.75s -221.00ms
dist/esm.1c9ef78b.js 63.49kb -134.00b 🚀 12.36s -998.00ms 🚀
dist/ElementBrowser.8e866a0e.js 62.33kb -132.00b 🚀 9.22s -256.00ms
dist/archive.a2217524.js 60.29kb -134.00b 🚀 12.36s -996.00ms 🚀
dist/esm.1a044825.js 59.85kb -134.00b 🚀 9.21s -266.00ms
dist/component-lazy.1b33c14d.js 59.63kb -134.00b 🚀 6.60s +280.00ms
dist/component.bb2f7991.js 58.01kb -134.00b 🚀 5.73s -235.00ms
dist/DatePicker.9c23032b.js 47.98kb -134.00b 🚀 6.59s -536.00ms 🚀
dist/esm.3fa8c7de.js 39.56kb -134.00b 🚀 12.36s -997.00ms 🚀
dist/Modal.ff929598.js 28.33kb -134.00b 🚀 5.73s -233.00ms
dist/DatePicker.a3ad9fca.js 25.15kb -134.00b 🚀 6.59s -536.00ms 🚀
dist/smartMediaEditor.0fdaaac3.js 21.89kb -134.00b 🚀 12.36s -997.00ms 🚀
dist/esm.699bbabf.js 20.65kb -134.00b 🚀 12.36s -997.00ms 🚀
dist/component.1c22aee9.js 18.81kb -134.00b 🚀 5.73s -232.00ms
dist/js.324be058.js 17.34kb -134.00b 🚀 5.73s -228.00ms
dist/ConfigPanelFieldsLoader.3cdf42ed.js 15.95kb -134.00b 🚀 9.22s -264.00ms
dist/ui.f919792f.js 14.62kb -134.00b 🚀 9.22s -257.00ms
dist/ConfigPanelFieldsLoader.0c1e88b7.js 13.78kb -134.00b 🚀 9.22s -257.00ms
dist/dropzone.7e088531.js 13.61kb -134.00b 🚀 12.36s -998.00ms 🚀
dist/pdfRenderer.187ba54d.js 12.21kb -132.00b 🚀 9.21s -267.00ms
dist/dropzone.09d0b890.js 11.64kb -134.00b 🚀 12.36s -998.00ms 🚀
dist/Toolbar.7b6f497e.js 9.53kb -134.00b 🚀 12.36s -996.00ms 🚀
dist/clipboard.f5f3497c.js 8.07kb -134.00b 🚀 12.36s -998.00ms 🚀
dist/mobile-upload.8bd7d5f3.js 7.99kb -134.00b 🚀 5.73s -234.00ms
dist/mobile-upload.41e1ddfc.js 7.99kb -134.00b 🚀 9.22s -257.00ms
dist/mobile-upload.f2b8a53f.js 7.99kb -134.00b 🚀 9.21s -267.00ms
dist/mobile-upload.40a8f0fb.js 7.99kb -134.00b 🚀 12.36s -997.00ms 🚀
dist/index.runtime.50c92a63.js 7.42kb -132.00b 🚀 12.36s -1.02s 🚀
dist/browser.333a8efe.js 7.33kb -134.00b 🚀 12.36s -999.00ms 🚀
dist/index.b16227d6.css 4.08kb +0.00b 12.37s -1.01s 🚀
dist/Modal.232b8600.js 4.00kb -134.00b 🚀 5.73s -234.00ms
dist/component.b84d6109.js 3.35kb -134.00b 🚀 5.73s -234.00ms
dist/media-viewer-analytics-error-boundary.c1511b0d.js 3.32kb -134.00b 🚀 12.36s -996.00ms 🚀
dist/media-picker-analytics-error-boundary.418c2c46.js 3.32kb -134.00b 🚀 12.36s -997.00ms 🚀
dist/media-card-analytics-error-boundary.7d513b72.js 3.32kb -134.00b 🚀 12.36s -996.00ms 🚀
dist/png-chunks-extract.c54842d7.js 3.19kb -134.00b 🚀 5.73s -228.00ms
dist/ru.896915b9.js 2.94kb -134.00b 🚀 9.21s -264.00ms
dist/uk.48c97550.js 2.89kb -134.00b 🚀 9.21s -265.00ms
dist/codeViewerRenderer.f99075be.js 2.74kb -134.00b 🚀 9.21s -266.00ms
dist/th.31044730.js 2.73kb -134.00b 🚀 9.21s -264.00ms
dist/ResourcedEmojiComponent.1ec35575.js 2.60kb -134.00b 🚀 6.59s -536.00ms 🚀
dist/pl.5f36d63e.js 2.38kb -134.00b 🚀 6.60s -530.00ms 🚀
dist/cs.971d1d60.js 2.36kb -134.00b 🚀 6.59s -536.00ms 🚀
dist/de.6efbb375.js 2.30kb -134.00b 🚀 6.60s -535.00ms 🚀
dist/fr.af2c92ae.js 2.25kb -134.00b 🚀 6.59s -536.00ms 🚀
dist/es.23f0c164.js 2.25kb -134.00b 🚀 6.60s -535.00ms 🚀
dist/hu.8323f36b.js 2.23kb -134.00b 🚀 6.59s -536.00ms 🚀
dist/fi.7ed4b1b5.js 2.22kb -134.00b 🚀 6.59s -536.00ms 🚀
dist/ja.5653161c.js 2.22kb -134.00b 🚀 6.60s -529.00ms 🚀
dist/vi.d8dcb67a.js 2.22kb -134.00b 🚀 9.21s -265.00ms
dist/pt_BR.eccfad73.js 2.19kb -134.00b 🚀 6.60s -530.00ms 🚀
dist/tr.46f26598.js 2.16kb -134.00b 🚀 9.21s -265.00ms
dist/ko.2cf2bbda.js 2.11kb -134.00b 🚀 6.60s -529.00ms 🚀
dist/sv.13d93533.js 2.10kb -134.00b 🚀 9.21s -264.00ms
dist/it.601d375a.js 2.10kb -134.00b 🚀 6.59s -536.00ms 🚀
dist/nb.b300dd3e.js 2.09kb -134.00b 🚀 6.60s -529.00ms 🚀
dist/date.7b2f9581.js 2.07kb -134.00b 🚀 5.96s -357.00ms 🚀
dist/da.21385cf2.js 2.07kb -134.00b 🚀 6.59s -536.00ms 🚀
dist/nl.3999ea58.js 2.07kb -134.00b 🚀 6.60s -529.00ms 🚀
dist/images.46c877f3.js 2.03kb -134.00b 🚀 5.96s -356.00ms 🚀
dist/zh_TW.afaf6222.js 1.98kb -134.00b 🚀 9.21s -265.00ms
dist/zh.fcdc32bb.js 1.96kb -134.00b 🚀 9.21s -265.00ms
dist/feedback.fd1f6260.js 1.89kb -134.00b 🚀 6.59s -536.00ms 🚀
dist/status.6f638b3d.js 1.80kb -134.00b 🚀 5.96s -356.00ms 🚀
dist/code.ef3dfa9c.js 1.69kb -134.00b 🚀 5.96s -357.00ms 🚀
dist/workerHasher.bfc999cd.js 1.69kb -134.00b 🚀 5.73s -228.00ms
dist/workerHasher.4b89e1de.js 1.69kb -134.00b 🚀 9.22s -256.00ms
dist/workerHasher.06536d4e.js 1.69kb -134.00b 🚀 9.22s -256.00ms
dist/workerHasher.dd4d2a38.js 1.69kb -134.00b 🚀 12.36s -998.00ms 🚀
dist/workerHasher.eae92e5c.js 1.69kb -134.00b 🚀 12.36s -997.00ms 🚀
dist/workerHasher.cfe5994f.js 1.69kb -134.00b 🚀 12.36s -997.00ms 🚀
dist/list-number.35bc7f17.js 1.60kb -134.00b 🚀 5.96s -357.00ms 🚀
dist/heading6.974f167d.js 1.49kb -134.00b 🚀 6.59s -535.00ms 🚀
dist/16.87c743d1.js 1.48kb -134.00b 🚀 5.74s -230.00ms
dist/heading3.9ad47cbe.js 1.48kb -134.00b 🚀 5.96s -357.00ms 🚀
dist/16.dd50aef4.js 1.41kb -134.00b 🚀 5.73s -234.00ms
dist/link.542e87bf.js 1.41kb -134.00b 🚀 5.96s -357.00ms 🚀
dist/emoji.79757e2c.js 1.38kb -134.00b 🚀 5.96s -357.00ms 🚀
dist/heading5.023a8f1f.js 1.36kb -134.00b 🚀 6.59s -535.00ms 🚀
dist/expand.801fc3a0.js 1.31kb -134.00b 🚀 6.59s -536.00ms 🚀
dist/heading2.bffcdf12.js 1.30kb -134.00b 🚀 5.96s -357.00ms 🚀
dist/heading4.05995ed9.js 1.25kb -134.00b 🚀 5.96s -357.00ms 🚀
dist/mention.adafe481.js 1.21kb -134.00b 🚀 5.96s -357.00ms 🚀
dist/layout.40f6b132.js 1.17kb -134.00b 🚀 5.96s -356.00ms 🚀
dist/divider.616b37d8.js 1.17kb -134.00b 🚀 5.96s -357.00ms 🚀
dist/action.361730a6.js 1.15kb -134.00b 🚀 5.96s -357.00ms 🚀
dist/heading1.495af5dc.js 1.14kb -134.00b 🚀 5.96s -357.00ms 🚀
dist/16.9e7cc0d9.js 1.13kb -134.00b 🚀 5.73s -234.00ms
dist/list.c5ad55b6.js 1.11kb -134.00b 🚀 5.96s -357.00ms 🚀
dist/quote.235ab420.js 1.11kb -134.00b 🚀 5.96s -356.00ms 🚀
dist/decision.36a0b771.js 1.10kb -134.00b 🚀 5.96s -357.00ms 🚀
dist/16.8d078bd1.js 1.08kb -134.00b 🚀 5.73s -234.00ms
dist/16.bb53313d.js 1.08kb -134.00b 🚀 5.73s -234.00ms
dist/panel-warning.7e72ad42.js 1.07kb -134.00b 🚀 5.96s -357.00ms 🚀
dist/16.88e24f19.js 1.06kb -134.00b 🚀 5.73s -234.00ms
dist/16.0d8c3c9e.js 1.06kb -134.00b 🚀 5.96s -356.00ms 🚀
dist/table.389f0908.js 1.05kb -134.00b 🚀 5.96s -357.00ms 🚀
dist/16.db9c75f1.js 1.03kb -134.00b 🚀 5.75s -233.00ms
dist/panel.7cee1972.js 1017.00b -134.00b 🚀 5.96s -357.00ms 🚀
dist/panel-error.e46252ff.js 994.00b -134.00b 🚀 5.96s -357.00ms 🚀
dist/16.c0880b62.js 992.00b -134.00b 🚀 5.74s -240.00ms
dist/16.99296be0.js 964.00b -134.00b 🚀 5.75s -231.00ms
dist/16.c16ee42d.js 957.00b -134.00b 🚀 5.73s -233.00ms
dist/16.dcf139e7.js 951.00b -134.00b 🚀 5.96s -357.00ms 🚀
dist/panel-success.dbd2515b.js 935.00b -134.00b 🚀 5.96s -357.00ms 🚀
dist/panel-note.b6c94ff5.js 925.00b -134.00b 🚀 5.96s -356.00ms 🚀
dist/16.26c3d518.js 912.00b -134.00b 🚀 5.74s -230.00ms
dist/16.f76b9cae.js 906.00b -134.00b 🚀 5.73s -234.00ms
dist/16.fb327623.js 906.00b -134.00b 🚀 5.73s -234.00ms
dist/16.f2056258.js 905.00b -134.00b 🚀 5.74s -230.00ms
dist/16.4e7dec68.js 904.00b -134.00b 🚀 5.73s -234.00ms
dist/16.400116d9.js 903.00b -134.00b 🚀 5.73s -234.00ms
dist/16.f6395317.js 876.00b -134.00b 🚀 5.96s -357.00ms 🚀
dist/16.24326b68.js 855.00b -134.00b 🚀 5.73s -233.00ms
dist/16.0285f4b2.js 827.00b -134.00b 🚀 5.74s -241.00ms
dist/sk.101f1705.js 786.00b -134.00b 🚀 9.21s -264.00ms
dist/pt_PT.402f9c4e.js 765.00b -134.00b 🚀 6.60s -529.00ms 🚀
dist/et.69382942.js 763.00b -134.00b 🚀 6.60s -536.00ms 🚀
dist/simpleHasher.2403fa32.js 719.00b -134.00b 🚀 5.73s -228.00ms
dist/simpleHasher.8b7def87.js 719.00b -134.00b 🚀 9.22s -256.00ms
dist/simpleHasher.38195df7.js 719.00b -134.00b 🚀 9.22s -257.00ms
dist/simpleHasher.308c3a38.js 719.00b -134.00b 🚀 12.36s -998.00ms 🚀
dist/simpleHasher.f29b9a84.js 719.00b -134.00b 🚀 12.36s -997.00ms 🚀
dist/simpleHasher.d2c7eaf0.js 719.00b -134.00b 🚀 12.36s -997.00ms 🚀
dist/is.5b945719.js 625.00b -134.00b 🚀 6.59s -536.00ms 🚀
dist/ro.a6eff34a.js 612.00b -134.00b 🚀 8.98s +1.85s ⚠️
dist/en_GB.61f7112a.js 602.00b -134.00b 🚀 6.60s -535.00ms 🚀
dist/en.41261459.js 599.00b -134.00b 🚀 6.60s -535.00ms 🚀
dist/index.html 248.00b +0.00b 6.59s -6.82s 🚀

Three.js ✅

Timings

Description Time Difference
Cold 3.56s +165.00ms
Cached 353.00ms -3.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/Three.js 572.22kb +0.00b 1.12s +65.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/Three.js 572.22kb +0.00b 1.14s +68.00ms ⚠️

Click here to view a detailed benchmark overview.

@mischnic
Copy link
Member

mischnic commented Aug 17, 2023 •
edited
Loading

Should we put that behind a browser version check and keep the older code for old browsers?

https://caniuse.com/?search=globalThis

parcel/packages/packagers/js/src/GlobalOutputFormat.js

Lines 15 to 17 in 5478f4a

let prelude = this.packager.bundle.env.supports('arrow-functions', true)
? '(() => {\n'
: '(function () {\n';

@alshdavid alshdavid force-pushed the alsh/remove-globalthis-polyfill-from-packager branch from 3ee570e to 65a6c06 Compare August 21, 2023 00:57
@alshdavid alshdavid force-pushed the alsh/remove-globalthis-polyfill-from-packager branch 4 times, most recently from 9f44fbf to dba4b8e Compare August 22, 2023 03:06
mattcompiles
mattcompiles approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@mattcompiles mattcompiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 👍

@alshdavid alshdavid force-pushed the alsh/remove-globalthis-polyfill-from-packager branch from dba4b8e to 0fb4c0f Compare August 22, 2023 03:51
@alshdavid alshdavid merged commit 702033b into v2 Aug 22, 2023
16 checks passed
@mischnic mischnic deleted the alsh/remove-globalthis-polyfill-from-packager branch August 22, 2023 12:43
@apiiro-snyk apiiro-snyk mentioned this pull request Jul 2, 2024
Open
@Codimow Codimow mentioned this pull request Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcompiles mattcompiles mattcompiles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alshdavid @parcel-benchmark @mischnic @mattcompiles