-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EntryResolver.resolveEntry infinite loop when entries look like globs #9020
Fix EntryResolver.resolveEntry infinite loop when entries look like globs #9020
Conversation
You need to have Rust installed and then run |
da5be1e
to
41cd2ad
Compare
I like better this last commit. I think it's simpler and faster, because it requires less stat checks operations. But the previous one will do the job too. |
ae48b72
to
d56daf3
Compare
Any chance on reviewing and merging this? |
d56daf3
to
607b33e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
↪️ Pull Request
#8519
💻 Examples
if you try to build any file whose path looks like a glob, like
/blog/[id].html
it will cause a infinite loop🚨 Test instructions
✔️ PR Todo
I wasn't able to run test locally, I am having this error:Even with v2 branch.I couldn't find any solution. Maybe I need some guidance.Also with the linter, It was erroring, but it was not showing any specific reason.